qml: correct mini block clock gradient direction

Author: johnny9

qml/components/blockclockdial.cpp

@@ -69,13 +69,16 @@ void BlockClockDial::setupSyncedGradient(const QRectF& bounds)
     m_synced_gradient_bounds = bounds;
     m_synced_gradient.setCenter(bounds.center());
     m_synced_gradient.setAngle(90);
-    m_synced_gradient.setColorAt(0, m_confirmation_colors[5]);
-    m_synced_gradient.setColorAt(0.16, m_confirmation_colors[5]);
-    m_synced_gradient.setColorAt(0.32, m_confirmation_colors[4]);
-    m_synced_gradient.setColorAt(0.48, m_confirmation_colors[3]);
-    m_synced_gradient.setColorAt(0.64, m_confirmation_colors[2]);
-    m_synced_gradient.setColorAt(0.8, m_confirmation_colors[1]);
-    m_synced_gradient.setColorAt(1, m_confirmation_colors[0]);
+    // The dial advances clockwise while conical gradients advance
+    // counter-clockwise. Mirror the stops so older time is more confirmed and
+    // the color moves toward zero confirmations as the dial advances.
+    m_synced_gradient.setColorAt(0, m_confirmation_colors[0]);
+    m_synced_gradient.setColorAt(0.2, m_confirmation_colors[1]);
+    m_synced_gradient.setColorAt(0.36, m_confirmation_colors[2]);
+    m_synced_gradient.setColorAt(0.52, m_confirmation_colors[3]);
+    m_synced_gradient.setColorAt(0.68, m_confirmation_colors[4]);
+    m_synced_gradient.setColorAt(0.84, m_confirmation_colors[5]);
+    m_synced_gradient.setColorAt(1, m_confirmation_colors[5]);
     m_synced_gradient_needs_update = false;
 }
 

test/test_blockclockdial.cpp

@@ -117,6 +117,7 @@ class BlockClockDialTests : public QObject
 private Q_SLOTS:
     void ibdProgressRendersImmediateHalfArc();
     void syncedGradientToggleChangesRenderedColors();
+    void syncedGradientRunsFromOlderToNewerConfirmationColors();
     void syncedGradientUpdatesWhenConfirmationColorsChange();
     void connectingDelayControlsInitialAnimation();
     void inactiveDialStopsAnimationAndRetainsLatestState();
@@ -175,6 +176,32 @@ void BlockClockDialTests::syncedGradientToggleChangesRenderedColors()
                             .arg(gradient_right.name(QColor::HexArgb), gradient_bottom.name(QColor::HexArgb))));
 }
 
+void BlockClockDialTests::syncedGradientRunsFromOlderToNewerConfirmationColors()
+{
+    BlockClockDial dial;
+    ConfigureDial(dial);
+    dial.setAnimateDial(false);
+    dial.setConnected(true);
+    dial.setSynced(true);
+    dial.setShowBlockSegments(false);
+    dial.setUseGradientArcWhenSynced(true);
+    dial.setCurrentTimeFraction(0.75);
+
+    const QImage image{RenderDial(dial)};
+    const QColor older_color{image.pixelColor(DialPoint(0.05))};
+    const QColor middle_color{image.pixelColor(DialPoint(0.375))};
+    const QColor newer_color{image.pixelColor(DialPoint(0.70))};
+
+    QVERIFY(ColorDistance(older_color, CONFIRMATION_COLORS[5]) <
+            ColorDistance(older_color, CONFIRMATION_COLORS[0]));
+    QVERIFY(ColorDistance(newer_color, CONFIRMATION_COLORS[0]) <
+            ColorDistance(older_color, CONFIRMATION_COLORS[0]));
+    QVERIFY(ColorDistance(older_color, CONFIRMATION_COLORS[5]) <
+            ColorDistance(newer_color, CONFIRMATION_COLORS[5]));
+    QVERIFY(older_color.green() > middle_color.green());
+    QVERIFY(middle_color.green() > newer_color.green());
+}
+
 void BlockClockDialTests::syncedGradientUpdatesWhenConfirmationColorsChange()
 {
     BlockClockDial dial;