Commit f840195
committed
qml: surface debug log open failures in the UI
DebugLogModel::openLogFile() already detects when the debug.log cannot be
opened (a missing file, or no application associated with the file type):
it sets an openError message, emits openErrorChanged, and returns false.
But SettingsDebugLog discarded the return value and never read openError,
so a failed open gave the user no feedback at all.
Bind the model's openError to an error label on the debug log page, the
same way the wallet backup page surfaces its open failure, so the user
sees why the log did not open.
Cover it both ways: a QML test (with a debug log model stub) checks the
error label shows on a failed open and clears on a later success, and a
C++ unit test checks the model's missing-file path returns false and sets
openError.1 parent 77ccd91 commit f840195
4 files changed
Lines changed: 136 additions & 3 deletions
File tree
- qml/pages/settings
- test
- qml
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
104 | 118 | | |
105 | 119 | | |
106 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3159 | 3159 | | |
3160 | 3160 | | |
3161 | 3161 | | |
3162 | | - | |
| 3162 | + | |
3163 | 3163 | | |
3164 | 3164 | | |
3165 | 3165 | | |
| |||
3170 | 3170 | | |
3171 | 3171 | | |
3172 | 3172 | | |
3173 | | - | |
| 3173 | + | |
| 3174 | + | |
| 3175 | + | |
| 3176 | + | |
| 3177 | + | |
| 3178 | + | |
| 3179 | + | |
| 3180 | + | |
| 3181 | + | |
| 3182 | + | |
| 3183 | + | |
| 3184 | + | |
| 3185 | + | |
| 3186 | + | |
| 3187 | + | |
| 3188 | + | |
| 3189 | + | |
| 3190 | + | |
| 3191 | + | |
| 3192 | + | |
| 3193 | + | |
| 3194 | + | |
| 3195 | + | |
3174 | 3196 | | |
3175 | 3197 | | |
3176 | 3198 | | |
| |||
3308 | 3330 | | |
3309 | 3331 | | |
3310 | 3332 | | |
| 3333 | + | |
| 3334 | + | |
| 3335 | + | |
3311 | 3336 | | |
3312 | 3337 | | |
3313 | 3338 | | |
| |||
3401 | 3426 | | |
3402 | 3427 | | |
3403 | 3428 | | |
| 3429 | + | |
3404 | 3430 | | |
3405 | 3431 | | |
3406 | 3432 | | |
| |||
3420 | 3446 | | |
3421 | 3447 | | |
3422 | 3448 | | |
3423 | | - | |
3424 | 3449 | | |
3425 | 3450 | | |
3426 | 3451 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
| 73 | + | |
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
| |||
607 | 609 | | |
608 | 610 | | |
609 | 611 | | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
610 | 641 | | |
611 | 642 | | |
612 | 643 | | |
| |||
0 commit comments