Merge #11: Fix clippy

1fabfe0 chore: Make clippy happy (志宇)
a1ddd5b clippy: address `clippy::large_enum_variant` by using `Box` (valued mammal)

Pull request description:

Top commit has no ACKs.

Tree-SHA512: 9b4519c2b1b76a04ca749d396ea0779e2a2dd36a8be4f438be939ef0569e9f67dc5377038de07b46c529d014aeb6fa9d7afbea702abecad4219e4d754d5aafe0

Author: evanlinjin

examples/synopsis.rs

@@ -31,7 +31,7 @@ fn main() -> anyhow::Result<()> {
     let txid = env.send(&addr, Amount::ONE_BTC)?;
     env.mine_blocks(1, None)?;
     wallet.sync(&env)?;
-    println!("Received {}", txid);
+    println!("Received {txid}");
     println!("Balance (confirmed): {}", wallet.balance());
 
     let txid = env.send(&addr, Amount::ONE_BTC)?;
@@ -88,14 +88,14 @@ fn main() -> anyhow::Result<()> {
 
     // We will try bump this tx fee.
     let txid = env.rpc_client().send_raw_transaction(&tx)?;
-    println!("tx broadcasted: {}", txid);
+    println!("tx broadcasted: {txid}");
     wallet.sync(&env)?;
     println!("Balance (send tx): {}", wallet.balance());
 
     // Try cancel a tx.
     // We follow all the rules as specified by
     // https://github.com/bitcoin/bitcoin/blob/master/doc/policy/mempool-replacements.md#current-replace-by-fee-policy
-    println!("OKAY LET's TRY CANCEL {}", txid);
+    println!("OKAY LET's TRY CANCEL {txid}");
     {
         let original_tx = wallet
             .graph
@@ -172,7 +172,7 @@ fn main() -> anyhow::Result<()> {
             ((fee.to_sat() as f32) / (tx.weight().to_vbytes_ceil() as f32)),
         );
         let txid = env.rpc_client().send_raw_transaction(&tx)?;
-        println!("tx broadcasted: {}", txid);
+        println!("tx broadcasted: {txid}");
         wallet.sync(&env)?;
         println!("Balance (RBF): {}", wallet.balance());
     }

src/canonical_unspents.rs

@@ -242,12 +242,12 @@ pub enum GetForeignUnspentError {
 impl fmt::Display for GetForeignUnspentError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            Self::Coinbase(err) => write!(f, "{}", err),
-            Self::FromPsbtInput(err) => write!(f, "{}", err),
+            Self::Coinbase(err) => write!(f, "{err}"),
+            Self::FromPsbtInput(err) => write!(f, "{err}"),
             Self::OutputIsAlreadySpent(op) => {
-                write!(f, "outpoint is already spent: {}", op)
+                write!(f, "outpoint is already spent: {op}")
             }
-            Self::UtxoMismatch(op) => write!(f, "UTXO mismatch: {}", op),
+            Self::UtxoMismatch(op) => write!(f, "UTXO mismatch: {op}"),
         }
     }
 }
@@ -269,9 +269,9 @@ pub enum ExtractReplacementsError {
 impl fmt::Display for ExtractReplacementsError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            Self::TransactionNotFound(txid) => write!(f, "transaction not found: {}", txid),
+            Self::TransactionNotFound(txid) => write!(f, "transaction not found: {txid}"),
             Self::CannotReplaceCoinbase => write!(f, "cannot replace a coinbase transaction"),
-            Self::PreviousOutputNotFound(op) => write!(f, "previous output not found: {}", op),
+            Self::PreviousOutputNotFound(op) => write!(f, "previous output not found: {op}"),
         }
     }
 }

src/input.rs

@@ -1,3 +1,4 @@
+use alloc::boxed::Box;
 use alloc::sync::Arc;
 use alloc::vec::Vec;
 use core::fmt;
@@ -34,9 +35,9 @@ impl TxStatus {
 
 #[derive(Debug, Clone)]
 enum PlanOrPsbtInput {
-    Plan(Plan),
+    Plan(Box<Plan>),
     PsbtInput {
-        psbt_input: psbt::Input,
+        psbt_input: Box<psbt::Input>,
         sequence: Sequence,
         absolute_timelock: absolute::LockTime,
         satisfaction_weight: usize,
@@ -57,7 +58,7 @@ impl PlanOrPsbtInput {
             return Err(FromPsbtInputError::UtxoCheck);
         }
         Ok(Self::PsbtInput {
-            psbt_input,
+            psbt_input: Box::new(psbt_input),
             sequence,
             absolute_timelock: absolute::LockTime::ZERO,
             satisfaction_weight,
@@ -166,9 +167,9 @@ pub enum FromPsbtInputError {
 impl fmt::Display for FromPsbtInputError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            Self::Coinbase(err) => write!(f, "{}", err),
+            Self::Coinbase(err) => write!(f, "{err}"),
             Self::InvalidOutPoint(op) => {
-                write!(f, "invalid outpoint: {}", op)
+                write!(f, "invalid outpoint: {op}")
             }
             Self::UtxoCheck => {
                 write!(
@@ -216,7 +217,7 @@ impl Input {
             prev_outpoint: OutPoint::new(tx.compute_txid(), output_index as _),
             prev_txout: tx.tx_out(output_index).cloned()?,
             prev_tx: Some(tx),
-            plan: PlanOrPsbtInput::Plan(plan),
+            plan: PlanOrPsbtInput::Plan(Box::new(plan)),
             status,
             is_coinbase,
         })
@@ -234,7 +235,7 @@ impl Input {
             prev_outpoint,
             prev_txout,
             prev_tx: None,
-            plan: PlanOrPsbtInput::Plan(plan),
+            plan: PlanOrPsbtInput::Plan(Box::new(plan)),
             status,
             is_coinbase,
         }

src/input_candidates.rs

@@ -228,12 +228,12 @@ impl<E: fmt::Display> fmt::Display for IntoSelectionError<E> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
             IntoSelectionError::Selector(error) => {
-                write!(f, "{}", error)
+                write!(f, "{error}")
             }
             IntoSelectionError::SelectionAlgorithm(error) => {
-                write!(f, "selection algorithm failed: {}", error)
+                write!(f, "selection algorithm failed: {error}")
             }
-            IntoSelectionError::CannotMeetTarget(error) => write!(f, "{}", error),
+            IntoSelectionError::CannotMeetTarget(error) => write!(f, "{error}"),
         }
     }
 }
@@ -275,9 +275,9 @@ pub enum PolicyFailure<PF> {
 impl<PF: fmt::Display> fmt::Display for PolicyFailure<PF> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            PolicyFailure::MissingOutputs(err) => write!(f, "{}", err),
+            PolicyFailure::MissingOutputs(err) => write!(f, "{err}"),
             PolicyFailure::PolicyFailure(err) => {
-                write!(f, "policy failure: {}", err)
+                write!(f, "policy failure: {err}")
             }
         }
     }

src/output.rs

@@ -1,3 +1,4 @@
+use alloc::boxed::Box;
 use bitcoin::{Amount, ScriptBuf, TxOut};
 use miniscript::bitcoin;
 
@@ -9,7 +10,7 @@ pub enum ScriptSource {
     /// bitcoin script
     Script(ScriptBuf),
     /// definite descriptor
-    Descriptor(DefiniteDescriptor),
+    Descriptor(Box<DefiniteDescriptor>),
 }
 
 impl From<ScriptBuf> for ScriptSource {
@@ -32,7 +33,7 @@ impl ScriptSource {
 
     /// From descriptor
     pub fn from_descriptor(descriptor: DefiniteDescriptor) -> Self {
-        Self::Descriptor(descriptor)
+        Self::Descriptor(Box::new(descriptor))
     }
 
     /// To ScriptBuf

src/selector.rs

@@ -243,8 +243,8 @@ pub enum SelectorError {
 impl fmt::Display for SelectorError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            Self::Miniscript(err) => write!(f, "{}", err),
-            Self::CannotMeetTarget(err) => write!(f, "{}", err),
+            Self::Miniscript(err) => write!(f, "{err}"),
+            Self::CannotMeetTarget(err) => write!(f, "{err}"),
         }
     }
 }