feat(wallet): add helper to compute balance with minimum confirmations #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17173539231Details
💛 - Coveralls |
There was a problem hiding this comment.
I think we should tackle #273 before going ahead with this.
Comment on lines
+1248
to
+1252
| let target_tip = self | ||
| .chain | ||
| .range(..=target_height) | ||
| .next() | ||
| .expect("local chain must contain genesis"); |
There was a problem hiding this comment.
🔧 This relies on there being a checkpoint in the local chain at the target_height. If there's not, then the next "tip" might be significantly lower. A better way IMO would be to pass the target height as input to FullTxOut::is_confirmed_and_spendable.
Then again, if a UTXO originally confirmed at height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements bdk#1942.
Description
This PR adds a new convenience method to
bdk_wallet::Walletfor computing balances with a configurable minimum confirmation threshold. This allows applications to easily query wallet balances that only include transactions with a specified number of confirmations.See: bitcoindevkit/bdk#2007 (review)
Changelog notice
balance_with_confirmation_depth()method to compute balance with a user-defined minimum number of confirmations.Checklists
All Submissions:
just pbefore pushingNew Features: