Fix orphaned SQLite files, error-swallowing set_wallet_type, and unconditional cache clear

- Defer BdkStore creation past fingerprint duplicate check so the
  upgrade early-return path no longer orphans a SQLite file on disk
- Make set_wallet_type return Result and write DB before updating
  in-memory state, so failures are surfaced instead of silently reverted
- Check walletId before clearing cached WalletManager on Android,
  matching existing iOS behavior

Author: praveenperera

android/app/src/main/java/org/bitcoinppl/cove/AppManager.kt

@@ -428,7 +428,11 @@ class AppManager private constructor() : FfiReconcile {
 
                 // upgrade watch-only → cold in-place
                 if (walletManager?.id == id && walletManager?.walletMetadata?.walletType != WalletType.HOT) {
-                    walletManager?.rust?.setWalletType(WalletType.COLD)
+                    try {
+                        walletManager?.rust?.setWalletType(WalletType.COLD)
+                    } catch (e: Exception) {
+                        Log.e(tag, "Failed to set wallet type to cold", e)
+                    }
                 }
             } finally {
                 wallet.close()
@@ -626,7 +630,9 @@ class AppManager private constructor() : FfiReconcile {
                 }
 
                 is AppStateReconcileMessage.ClearCachedWalletManager -> {
-                    clearWalletManager()
+                    if (walletManager?.id == message.v1) {
+                        clearWalletManager()
+                    }
                 }
 
                 is AppStateReconcileMessage.ShowLoadingPopup -> {

ios/Cove/CoveApp.swift

@@ -338,7 +338,7 @@ struct CoveApp: App {
 
             // upgrade watch-only → cold in-place
             if app.walletManager?.id == id, app.walletManager?.walletMetadata.walletType != .hot {
-                app.walletManager?.rust.setWalletType(walletType: .cold)
+                try app.walletManager?.rust.setWalletType(walletType: .cold)
             }
         } catch let WalletError.WalletAlreadyExists(id) {
             app.alertState = TaggedItem(.duplicateWallet(walletId: id))

rust/src/manager/wallet_manager.rs

@@ -197,6 +197,9 @@ pub enum WalletManagerError {
     #[error("unable to get next address: {0}")]
     NextAddressError(String),
 
+    #[error("unable to set wallet type: {0}")]
+    SetWalletTypeError(String),
+
     #[error("unable to get height")]
     GetHeightError,
 
@@ -912,18 +915,19 @@ impl RustWalletManager {
     }
 
     #[uniffi::method]
-    pub fn set_wallet_type(&self, wallet_type: WalletType) {
-        let metadata = {
-            let mut metadata = self.metadata.write();
-            metadata.wallet_type = wallet_type;
-            metadata.clone()
-        };
+    pub fn set_wallet_type(&self, wallet_type: WalletType) -> Result<(), Error> {
+        let mut metadata = self.metadata.read().clone();
+        metadata.wallet_type = wallet_type;
 
-        self.reconciler.send(Message::WalletMetadataChanged(metadata.clone()));
+        Database::global()
+            .wallets
+            .update_wallet_metadata(metadata.clone())
+            .map_err(|e| Error::SetWalletTypeError(format!("{e:?}")))?;
 
-        if let Err(error) = Database::global().wallets.update_wallet_metadata(metadata) {
-            error!("Unable to update wallet metadata: {error:?}");
-        }
+        *self.metadata.write() = metadata.clone();
+        self.reconciler.send(Message::WalletMetadataChanged(metadata));
+
+        Ok(())
     }
 
     #[uniffi::method]

rust/src/wallet.rs

@@ -269,8 +269,6 @@ impl Wallet {
         let id = WalletId::new();
         let mut metadata = WalletMetadata::new_for_hardware(id.clone(), "", None);
 
-        let mut store = BdkStore::try_new(&id, network).map_err_str(WalletError::LoadError)?;
-
         let pubport_descriptors = match pubport {
             Format::Descriptor(descriptors) => descriptors,
             Format::Json(json) => {
@@ -334,6 +332,8 @@ impl Wallet {
             }
         }
 
+        let mut store = BdkStore::try_new(&id, network).map_err_str(WalletError::LoadError)?;
+
         let fingerprint = fingerprint.map(|s| s.to_string());
 
         metadata.name = match &fingerprint {