Skip to content

Commit 675d695

Browse files
authored
Merge pull request #568 from bitfinexcom/staging
Release version 4.39.0
2 parents e278dd4 + 434d640 commit 675d695

34 files changed

+2734
-1370
lines changed

.env.example

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ SHOULD_LOCALHOST_BE_USED_FOR_LOADING_UI_IN_DEV_MODE=0
1111
EP_GH_IGNORE_TIME=true
1212
GH_TOKEN=
1313

14+
ARCH=x64
1415
NOTARIZE=0
1516
APPLE_TEAM_ID=
1617
APPLE_ID=

.github/workflows/build-electron-app.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ on:
2929
env:
3030
DOCKER_BUILDKIT: 1
3131
COMPOSE_DOCKER_CLI_BUILD: 1
32+
ARCH: x64
3233

3334
jobs:
3435
linux-win-docker-builder:
@@ -128,7 +129,7 @@ jobs:
128129
129130
mac-builder:
130131
timeout-minutes: 150
131-
runs-on: macos-15
132+
runs-on: macos-15-intel
132133
steps:
133134
- name: Checkout
134135
uses: actions/checkout@v4
@@ -161,7 +162,7 @@ jobs:
161162
fi
162163
- uses: actions/setup-node@v4
163164
with:
164-
node-version: 20.18.1
165+
node-version: 22.19.0
165166
- name: Cache Electron binaries
166167
id: electron-cache
167168
uses: actions/cache@v4
@@ -185,6 +186,8 @@ jobs:
185186
CSC_KEY_PASSWORD: ${{ secrets.BFX_APPLE_BUILD_CERTIFICATE_PASSWORD }}
186187
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
187188
ELECTRON_CACHE: ${{ runner.temp }}/.cache/electron
189+
# https://github.com/electron-userland/electron-builder/issues/3179
190+
USE_HARD_LINKS: false
188191
with:
189192
timeout_minutes: 40
190193
retry_wait_seconds: 10
@@ -231,7 +234,7 @@ jobs:
231234
uses: actions/checkout@v4
232235
- uses: actions/setup-node@v4
233236
with:
234-
node-version: 20.18.1
237+
node-version: 22.19.0
235238
- name: Install main dev deps
236239
run: npm i --development --no-audit --progress=false --force
237240
- name: Download Linux Unpacked build
@@ -263,7 +266,7 @@ jobs:
263266
uses: actions/checkout@v4
264267
- uses: actions/setup-node@v4
265268
with:
266-
node-version: 20.18.1
269+
node-version: 22.19.0
267270
- name: Install main dev deps
268271
run: npm i --development --no-audit --progress=false --force
269272
- name: Download Linux Unpacked build
@@ -297,7 +300,7 @@ jobs:
297300
uses: ./.github/actions/prepare-mac-runner
298301
- uses: actions/setup-node@v4
299302
with:
300-
node-version: 20.18.1
303+
node-version: 22.19.0
301304
- name: Install main dev deps
302305
run: npm i --development --no-audit --progress=false --force
303306
- name: Download Mac Unpacked build

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
submodules: recursive
2121
- uses: actions/setup-node@v4
2222
with:
23-
node-version: 20.18.1
23+
node-version: 22.19.0
2424
- name: Setup configs and install deps
2525
run: ./scripts/setup.sh -u
2626
- name: Run tests

CHANGELOG.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,41 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [4.39.0] - 2025-11-19
11+
12+
### Added
13+
14+
- Added `summary statistics` info into `getSummaryByAsset` endpoint. PR: [bfx-reports-framework#485](https://github.com/bitfinexcom/bfx-reports-framework/pull/485)
15+
- Added ability to send event to UI to refresh menu states and rerender to be able to show/hide/enable/disable the menu items dynamically, eg menu items like changelog or update. PR: [bfx-report-electron#565](https://github.com/bitfinexcom/bfx-report-electron/pull/565)
16+
- Provided `DEB` installable package for `Linux` for better UX giving more native behavior. PR: [bfx-report-electron#564](https://github.com/bitfinexcom/bfx-report-electron/pull/564)
17+
- Implemented the `Statistics` section for the app `Summary` page and predefined `unrealized` profits accounting (should always be included) for the summary by assets and statistics calculations. PR: [bfx-report-ui#977](https://github.com/bitfinexcom/bfx-report-ui/pull/977)
18+
19+
### Changed
20+
21+
- Updated `better-sqlite3` version up to `12.4.1` to have the last binary prebuild and be able to launch the driver under `electron` `v38`. PR: [bfx-facs-db-better-sqlite#13](https://github.com/bitfinexcom/bfx-facs-db-better-sqlite/pull/13)
22+
- Reduced WS connection frequency to avoid overloading the backend, added a small `300ms` delay to help balance the amount of reconnection instead of the forward recursion. PR: [bfx-report-ui#983](https://github.com/bitfinexcom/bfx-report-ui/pull/983)
23+
- Separated DB files for the `prod` and `staging` to prevent mixing data when testing. In general the issue is in the candles table. It's a public endpoint, and we don't associate it with a specific user id. And it means we can sync staging candles and mix them up with prod candles. As a good solution would be better to separate DB files for prod and staging. PRs: [bfx-reports-framework#488](https://github.com/bitfinexcom/bfx-reports-framework/pull/488), [bfx-report-electron#562](https://github.com/bitfinexcom/bfx-report-electron/pull/562)
24+
- Moved `auto-update` toast UI under main UI control instead of creating new windows using `electron-alert` lib. PR: [bfx-report-electron#566](https://github.com/bitfinexcom/bfx-report-electron/pull/566)
25+
- Enabled login via `__bfx_token` possibility for all environments and adjusted login type priority. PR: [bfx-report-ui#974](https://github.com/bitfinexcom/bfx-report-ui/pull/974)
26+
- Predefined the timeframe as a `day` and included `unrealized` profits as a default for the `Account Balance` section, like we already had for other sections, for represented data consistency. Removed the unused selectors and the `Filter` button, also implemented an auto-refreshing for all sections on the `Date` range changes for a cleaner UI and intuitive UX. PR: [bfx-report-ui#978](https://github.com/bitfinexcom/bfx-report-ui/pull/978)
27+
- Removed the `Filter` button from the `Account Balance` report and implemented an auto-refreshing on each parameter change for a cleaner UI and intuitive UX. PR: [bfx-report-ui#980](https://github.com/bitfinexcom/bfx-report-ui/pull/980)
28+
- Removed the `Filter` button from the `Analysis & Statistics` sections (Weighted Averages, Traded Volume, Average Win/Loss, Concentration Risk, Loan Report, Fees Report) and implemented an auto-refreshing on each parameter change for a cleaner UI and intuitive UX. PR: [bfx-report-ui#982](https://github.com/bitfinexcom/bfx-report-ui/pull/982)
29+
- Removed the `Generate` button from the `Tax Report` and implemented an auto-refreshing on each parameter change for a cleaner UI and intuitive UX. Prevented changing the params possibility(auto-refresh) during the report generation and initial sync to avoid errors. PR: [bfx-report-ui#984](https://github.com/bitfinexcom/bfx-report-ui/pull/984)
30+
- Removed the `Filter` button from the `Snapshots` sections (Positions, Tickers, Wallets) and implemented an auto-refreshing on each parameter change for a cleaner UI and intuitive UX. Prevented changing the params possibility(auto-refresh) during the report loading and initial sync to avoid errors. PR: [bfx-report-ui#985](https://github.com/bitfinexcom/bfx-report-ui/pull/985)
31+
- Changed the link for the `Bitfinex` logo from https://www.bitfinex.com to https://trading.bitfinex.com/t. PR: [bfx-report-ui#986](https://github.com/bitfinexcom/bfx-report-ui/pull/986)
32+
- Removed the `Filter` button from the `My History` reports(Ledgers, Movements, Balances, Earnings sections, Trades sections, Orders, Positions sections, Funding sections) and implemented an auto-refreshing on each parameter change for a cleaner UI and intuitive UX. PR: [bfx-report-ui#987](https://github.com/bitfinexcom/bfx-report-ui/pull/987)
33+
- Removed the `Filter` button from the Public Trades, Public Funding, Spot, Derivatives, Login History, Change Logs reports and implemented an auto-refreshing on each parameter change. PR: [bfx-report-ui#988](https://github.com/bitfinexcom/bfx-report-ui/pull/988)
34+
35+
### Fixed
36+
37+
- Fixed `winston` write stream issue in hot reload dev mode. PRs: [bfx-report-express#54](https://github.com/bitfinexcom/bfx-report-express/pull/54), [bfx-report#453](https://github.com/bitfinexcom/bfx-report/pull/453)
38+
- Fixed `database is locked` issue after DB driver update for the `updateSubAccount` endpoint. PR: [bfx-reports-framework#489](https://github.com/bitfinexcom/bfx-reports-framework/pull/489)
39+
- Fixed `symbol` params mapping for the test pairs (should be `tTESTBTC:TESTUSD` instead of `tBTC:TESTUSD` etc.) that cause errors. PR: [bfx-report-ui#973](https://github.com/bitfinexcom/bfx-report-ui/pull/973)
40+
41+
### Security
42+
43+
- Migrated `electron-updater` from `v5` to `v6`. This is necessary to add `DEB` release as a new version of lib supports it (it adds the installable experience for Linux users and fixes the missing app icon), and also fixed the high-severity [vulnerability](https://github.com/advisories/GHSA-9jxc-qjr9-vjxq) of the electron app
44+
1045
## [4.38.0] - 2025-10-08
1146

1247
### Added

Dockerfile.linux-builder

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
FROM electronuserland/builder:20
1+
FROM electronuserland/builder:22
22

3-
ARG NODE_VERSION="20.18.1"
3+
ARG NODE_VERSION="22.19.0"
44

55
ENV IS_BFX_API_STAGING=${IS_BFX_API_STAGING:-0}
66
ENV IS_DEV_ENV=${IS_DEV_ENV:-0}

Dockerfile.mac-builder

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
FROM electronuserland/builder:20
1+
FROM electronuserland/builder:22
22

3-
ARG NODE_VERSION="20.18.1"
3+
ARG NODE_VERSION="22.19.0"
44

55
ENV IS_BFX_API_STAGING=${IS_BFX_API_STAGING:-0}
66
ENV IS_DEV_ENV=${IS_DEV_ENV:-0}

Dockerfile.ui-builder

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
FROM electronuserland/builder:20
1+
FROM electronuserland/builder:22
22

3-
ARG NODE_VERSION="20.18.1"
3+
ARG NODE_VERSION="22.19.0"
44

55
ENV IS_BFX_API_STAGING=${IS_BFX_API_STAGING:-0}
66
ENV IS_DEV_ENV=${IS_DEV_ENV:-0}

Dockerfile.win-builder

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
FROM electronuserland/builder:20-wine
1+
FROM electronuserland/builder:22-wine
22

3-
ARG NODE_VERSION="20.18.1"
3+
ARG NODE_VERSION="22.19.0"
44

55
ENV IS_BFX_API_STAGING=${IS_BFX_API_STAGING:-0}
66
ENV IS_DEV_ENV=${IS_DEV_ENV:-0}

bfx-report-ui

Submodule bfx-report-ui updated 93 files

0 commit comments

Comments
 (0)