Skip to content

Commit dd7c536

Browse files
jeojoejeojoe
authored
Merge pull request #622 from bitfinexcom/staging
Release version 4.44.0
2 parents 0235501 + 175c9b8 commit dd7c536

14 files changed

Lines changed: 305 additions & 159 deletions

File tree

‎.github/workflows/build-electron-app.yml‎

Lines changed: 44 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
runs-on: ubuntu-22.04
3838
steps:
3939
- name: Checkout
40-
uses: actions/checkout@v4
40+
uses: actions/checkout@v6.0.2
4141
with:
4242
submodules: recursive
4343
- if: github.event.inputs.version != ''
@@ -63,7 +63,7 @@ jobs:
6363
fi
6464
- name: Cache Electron binaries
6565
id: electron-cache
66-
uses: actions/cache@v4
66+
uses: actions/cache@v5.0.4
6767
env:
6868
cache-name: electron-cache-v1
6969
with:
@@ -75,7 +75,7 @@ jobs:
7575
${{ runner.os }}-build-${{ env.cache-name }}-
7676
- name: Build release
7777
id: release-builder
78-
uses: nick-fields/retry@v3
78+
uses: nick-fields/retry@v4.0.0
7979
continue-on-error: false
8080
env:
8181
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -93,20 +93,20 @@ jobs:
9393
- name: Zip Linux Unpacked build
9494
run: zip -r dist/linux-unpacked.zip dist/linux-unpacked
9595
- name: Upload Linux Unpacked build
96-
uses: actions/upload-artifact@v4
96+
uses: actions/upload-artifact@v7.0.0
9797
with:
9898
name: linux-unpacked
9999
path: dist/linux-unpacked.zip
100100
- name: Zip Win Unpacked build
101101
run: zip -r dist/win-unpacked.zip dist/win-unpacked
102102
- name: Upload Win Unpacked build
103-
uses: actions/upload-artifact@v4
103+
uses: actions/upload-artifact@v7.0.0
104104
with:
105105
name: win-unpacked
106106
path: dist/win-unpacked.zip
107107
- if: env.REPO_OWNER != github.repository_owner
108108
name: Upload Linux Dist Release
109-
uses: actions/upload-artifact@v4
109+
uses: actions/upload-artifact@v7.0.0
110110
with:
111111
name: linux-dist-release
112112
path: |
@@ -115,7 +115,7 @@ jobs:
115115
dist/latest-linux.yml
116116
- if: env.REPO_OWNER != github.repository_owner
117117
name: Upload Win Dist Release
118-
uses: actions/upload-artifact@v4
118+
uses: actions/upload-artifact@v7.0.0
119119
with:
120120
name: win-dist-release
121121
path: |
@@ -132,7 +132,7 @@ jobs:
132132
runs-on: macos-15-intel
133133
steps:
134134
- name: Checkout
135-
uses: actions/checkout@v4
135+
uses: actions/checkout@v6.0.2
136136
with:
137137
submodules: recursive
138138
- if: github.event.inputs.version != ''
@@ -160,12 +160,12 @@ jobs:
160160
else
161161
echo "REPO_OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
162162
fi
163-
- uses: actions/setup-node@v4
163+
- uses: actions/setup-node@v6.3.0
164164
with:
165165
node-version: 24.14.0
166166
- name: Cache Electron binaries
167167
id: electron-cache
168-
uses: actions/cache@v4
168+
uses: actions/cache@v5.0.4
169169
env:
170170
cache-name: electron-cache-v1
171171
with:
@@ -176,7 +176,7 @@ jobs:
176176
${{ runner.os }}-build-${{ env.cache-name }}-
177177
- name: Build release
178178
id: release-builder
179-
uses: nick-fields/retry@v3
179+
uses: nick-fields/retry@v4.0.0
180180
continue-on-error: false
181181
env:
182182
APPLE_TEAM_ID: ${{ secrets.BFX_APPLE_TEAM_ID }}
@@ -208,13 +208,13 @@ jobs:
208208
- name: Zip Mac Unpacked build
209209
run: zip -r dist/mac.zip dist/mac
210210
- name: Upload Mac Unpacked build
211-
uses: actions/upload-artifact@v4
211+
uses: actions/upload-artifact@v7.0.0
212212
with:
213213
name: mac-unpacked
214214
path: dist/mac.zip
215215
- if: env.REPO_OWNER != github.repository_owner
216216
name: Upload Mac Dist Release
217-
uses: actions/upload-artifact@v4
217+
uses: actions/upload-artifact@v7.0.0
218218
with:
219219
name: mac-dist-release
220220
path: |
@@ -231,7 +231,7 @@ jobs:
231231
needs: [linux-win-docker-builder, mac-builder]
232232
steps:
233233
- name: Checkout
234-
uses: actions/checkout@v4
234+
uses: actions/checkout@v6.0.2
235235
- name: Get release version
236236
id: version
237237
run: |
@@ -251,7 +251,7 @@ jobs:
251251
echo "$CONTENT" >> $GITHUB_OUTPUT
252252
echo "EOF" >> $GITHUB_OUTPUT
253253
- name: Update matching draft release
254-
uses: actions/github-script@v8
254+
uses: actions/github-script@v9.0.0
255255
env:
256256
VERSION: ${{ steps.version.outputs.version }}
257257
CONTENT: ${{ steps.changelog.outputs.content }}
@@ -285,6 +285,7 @@ jobs:
285285
owner: context.repo.owner,
286286
repo: context.repo.repo,
287287
release_id: draft.id,
288+
tag_name: draft.tag_name || `v${version}`,
288289
body: content,
289290
})
290291
linux-e2e-test-runner:
@@ -294,27 +295,25 @@ jobs:
294295
needs: [linux-win-docker-builder]
295296
steps:
296297
- name: Checkout
297-
uses: actions/checkout@v4
298-
- uses: actions/setup-node@v4
298+
uses: actions/checkout@v6.0.2
299+
- uses: actions/setup-node@v6.3.0
299300
with:
300301
node-version: 24.14.0
301302
- name: Install main dev deps
302-
run: npm i --development --no-audit --progress=false --force
303+
run: npm ci --no-audit --force
303304
- name: Download Linux Unpacked build
304-
uses: actions/download-artifact@v4
305+
uses: actions/download-artifact@v8.0.0
305306
with:
306307
name: linux-unpacked
307308
path: dist
308309
- name: Unzip Linux Unpacked build
309310
run: unzip dist/linux-unpacked.zip
310311
- name: Run tests
311-
uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
312-
with:
313-
run: npm run e2e
312+
run: npm run e2e
314313
- name: Normalize E2E test report
315314
run: node ./scripts/node/normalize-e2e-test-report e2e-test-report.xml
316315
- name: Upload Linux E2E test results
317-
uses: actions/upload-artifact@v4
316+
uses: actions/upload-artifact@v7.0.0
318317
with:
319318
name: linux-e2e-test-results
320319
path: e2e-test-report.xml
@@ -326,27 +325,25 @@ jobs:
326325
needs: [linux-win-docker-builder]
327326
steps:
328327
- name: Checkout
329-
uses: actions/checkout@v4
330-
- uses: actions/setup-node@v4
328+
uses: actions/checkout@v6.0.2
329+
- uses: actions/setup-node@v6.3.0
331330
with:
332331
node-version: 24.14.0
333332
- name: Install main dev deps
334-
run: npm i --development --no-audit --progress=false --force
333+
run: npm ci --no-audit --force
335334
- name: Download Linux Unpacked build
336-
uses: actions/download-artifact@v4
335+
uses: actions/download-artifact@v8.0.0
337336
with:
338337
name: win-unpacked
339338
path: dist
340339
- name: Unzip Win Unpacked build
341340
run: 7z -y x dist/win-unpacked.zip
342341
- name: Run tests
343-
uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
344-
with:
345-
run: npm run e2e
342+
run: npm run e2e
346343
- name: Normalize E2E test report
347344
run: node ./scripts/node/normalize-e2e-test-report e2e-test-report.xml
348345
- name: Upload Win E2E test results
349-
uses: actions/upload-artifact@v4
346+
uses: actions/upload-artifact@v7.0.0
350347
with:
351348
name: win-e2e-test-results
352349
path: e2e-test-report.xml
@@ -358,29 +355,37 @@ jobs:
358355
needs: [mac-builder]
359356
steps:
360357
- name: Checkout
361-
uses: actions/checkout@v4
358+
uses: actions/checkout@v6.0.2
362359
- name: Prepare Mac runner
363360
uses: ./.github/actions/prepare-mac-runner
364-
- uses: actions/setup-node@v4
361+
- uses: actions/setup-node@v6.3.0
365362
with:
366363
node-version: 24.14.0
367364
- name: Install main dev deps
368-
run: npm i --development --no-audit --progress=false --force
365+
run: npm ci --no-audit --force
369366
- name: Download Mac Unpacked build
370-
uses: actions/download-artifact@v4
367+
uses: actions/download-artifact@v8.0.0
371368
with:
372369
name: mac-unpacked
373370
path: dist
374371
- name: Unzip Mac Unpacked build
375372
run: unzip dist/mac.zip
376373
- name: Run tests
377-
uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
378-
with:
379-
run: npm run e2e
374+
run: npm run e2e
380375
- name: Normalize E2E test report
381376
run: node ./scripts/node/normalize-e2e-test-report e2e-test-report.xml
382377
- name: Upload Mac E2E test results
383-
uses: actions/upload-artifact@v4
378+
uses: actions/upload-artifact@v7.0.0
384379
with:
385380
name: mac-e2e-test-results
386381
path: e2e-test-report.xml
382+
web-page-report:
383+
needs:
384+
- linux-e2e-test-runner
385+
- win-e2e-test-runner
386+
- mac-e2e-test-runner
387+
permissions:
388+
contents: read
389+
actions: read
390+
checks: write
391+
uses: ./.github/workflows/e2e-test-report.yml

‎.github/workflows/ci.yml‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,25 +15,25 @@ jobs:
1515
runs-on: ubuntu-22.04
1616
steps:
1717
- name: Checkout
18-
uses: actions/checkout@v4
18+
uses: actions/checkout@v6.0.2
1919
with:
2020
submodules: recursive
21-
- uses: actions/setup-node@v4
21+
- uses: actions/setup-node@v6.3.0
2222
with:
2323
node-version: 24.14.0
2424
- name: Setup configs and install deps
2525
run: ./scripts/setup.sh -u
2626
- name: Run tests
27-
uses: nick-fields/retry@v3
28-
continue-on-error: false
29-
with:
30-
timeout_minutes: 20
31-
retry_wait_seconds: 10
32-
max_attempts: 3
33-
retry_on: any
34-
command: npm test -- -- --reporter=json --reporter-option output=test-report.json
35-
- uses: actions/upload-artifact@v4
27+
run: npm test -- -- --reporter=json --reporter-option output=test-report.json
28+
- uses: actions/upload-artifact@v7.0.0
3629
if: success() || failure()
3730
with:
3831
name: test-results
3932
path: test-report.json
33+
web-page-report:
34+
needs: linux-test-runner
35+
permissions:
36+
contents: read
37+
actions: read
38+
checks: write
39+
uses: ./.github/workflows/test-report.yml

‎.github/workflows/e2e-test-report.yml‎

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@ name: 'E2E Test Report'
22
run-name: 'E2E Test Report: Commit ${{ github.sha }}'
33

44
on:
5-
workflow_run:
6-
workflows: ['Build release']
7-
types:
8-
- completed
5+
workflow_call
96

107
permissions:
118
contents: read
@@ -16,56 +13,51 @@ jobs:
1613
e2e-web-page-report:
1714
name: E2E Web Page Report
1815
runs-on: ubuntu-22.04
19-
if: ${{ github.event.workflow_run.conclusion == 'success' }}
2016
steps:
2117
- name: Download Linux E2E test results
22-
uses: actions/download-artifact@v4
18+
uses: actions/download-artifact@v8.0.0
2319
with:
24-
run-id: ${{ github.event.workflow_run.id }}
2520
github-token: ${{ secrets.GITHUB_TOKEN }}
2621
name: linux-e2e-test-results
2722
path: linux-e2e-test-results
28-
- uses: dorny/test-reporter@v1.8.0
23+
- uses: dorny/test-reporter@v3.0.0
2924
id: linux-e2e-test-results
3025
with:
3126
name: Linux E2E Tests
27+
report-title: Linux E2E Tests
3228
path: linux-e2e-test-results/e2e-test-report.xml
3329
reporter: jest-junit
30+
collapsed: never
3431
# Workaround for error 'fatal: not a git repository' caused by a call to 'git ls-files'
3532
# See: https://github.com/dorny/test-reporter/issues/169#issuecomment-1583560458
3633
max-annotations: 0
3734
- name: Download Win E2E test results
38-
uses: actions/download-artifact@v4
35+
uses: actions/download-artifact@v8.0.0
3936
with:
40-
run-id: ${{ github.event.workflow_run.id }}
4137
github-token: ${{ secrets.GITHUB_TOKEN }}
4238
name: win-e2e-test-results
4339
path: win-e2e-test-results
44-
- uses: dorny/test-reporter@v1.8.0
40+
- uses: dorny/test-reporter@v3.0.0
4541
id: win-e2e-test-results
4642
with:
4743
name: Win E2E Tests
44+
report-title: Win E2E Tests
4845
path: win-e2e-test-results/e2e-test-report.xml
4946
reporter: jest-junit
47+
collapsed: never
5048
max-annotations: 0
5149
- name: Download Mac E2E test results
52-
uses: actions/download-artifact@v4
50+
uses: actions/download-artifact@v8.0.0
5351
with:
54-
run-id: ${{ github.event.workflow_run.id }}
5552
github-token: ${{ secrets.GITHUB_TOKEN }}
5653
name: mac-e2e-test-results
5754
path: mac-e2e-test-results
58-
- uses: dorny/test-reporter@v1.8.0
55+
- uses: dorny/test-reporter@v3.0.0
5956
id: mac-e2e-test-results
6057
with:
6158
name: Mac E2E Tests
59+
report-title: Mac E2E Tests
6260
path: mac-e2e-test-results/e2e-test-report.xml
6361
reporter: jest-junit
62+
collapsed: never
6463
max-annotations: 0
65-
- name: E2E Test Report Summary
66-
run: |
67-
echo "### E2E Test Report page is ready! :rocket:" >> $GITHUB_STEP_SUMMARY
68-
echo "And available at the following links for applicable OSs:" >> $GITHUB_STEP_SUMMARY
69-
echo "- [Linux](${{ steps.linux-e2e-test-results.outputs.url_html }})" >> $GITHUB_STEP_SUMMARY
70-
echo "- [Win](${{ steps.win-e2e-test-results.outputs.url_html }})" >> $GITHUB_STEP_SUMMARY
71-
echo "- [Mac](${{ steps.mac-e2e-test-results.outputs.url_html }})" >> $GITHUB_STEP_SUMMARY

0 commit comments

Comments
 (0)