Skip to content

Commit 36f5848

Browse files
committed
Added padding to all screens
Signed-off-by: Arnau Mora <[email protected]>
1 parent 5021526 commit 36f5848

File tree

3 files changed

+12
-29
lines changed

3 files changed

+12
-29
lines changed

app/src/main/kotlin/at/bitfire/davdroid/ui/AccountsDrawerHandler.kt

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,13 @@ package at.bitfire.davdroid.ui
77
import android.content.ActivityNotFoundException
88
import android.content.Context
99
import android.content.Intent
10-
import android.content.res.Configuration
1110
import androidx.annotation.StringRes
1211
import androidx.compose.foundation.background
1312
import androidx.compose.foundation.layout.Box
1413
import androidx.compose.foundation.layout.Column
1514
import androidx.compose.foundation.layout.Spacer
16-
import androidx.compose.foundation.layout.displayCutoutPadding
1715
import androidx.compose.foundation.layout.fillMaxWidth
1816
import androidx.compose.foundation.layout.height
19-
import androidx.compose.foundation.layout.navigationBarsPadding
2017
import androidx.compose.foundation.layout.padding
2118
import androidx.compose.foundation.layout.size
2219
import androidx.compose.foundation.layout.statusBarsPadding
@@ -46,7 +43,6 @@ import androidx.compose.ui.graphics.RectangleShape
4643
import androidx.compose.ui.graphics.painter.Painter
4744
import androidx.compose.ui.graphics.vector.ImageVector
4845
import androidx.compose.ui.graphics.vector.rememberVectorPainter
49-
import androidx.compose.ui.platform.LocalConfiguration
5046
import androidx.compose.ui.platform.LocalContext
5147
import androidx.compose.ui.platform.LocalInspectionMode
5248
import androidx.compose.ui.res.painterResource
@@ -82,18 +78,9 @@ abstract class AccountsDrawerHandler {
8278
snackbarHostState: SnackbarHostState,
8379
onCloseDrawer: () -> Unit
8480
) {
85-
val conf = LocalConfiguration.current
86-
val isHorizontal = conf.orientation == Configuration.ORIENTATION_LANDSCAPE
8781
Column(modifier = Modifier
8882
.fillMaxWidth()
8983
.verticalScroll(rememberScrollState())
90-
.let { mod ->
91-
if (isHorizontal) {
92-
mod.displayCutoutPadding()
93-
} else {
94-
mod.navigationBarsPadding()
95-
}
96-
}
9784
) {
9885
BrandingHeader()
9986

app/src/main/kotlin/at/bitfire/davdroid/ui/AccountsScreen.kt

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ package at.bitfire.davdroid.ui
77
import android.Manifest
88
import android.accounts.Account
99
import android.content.Intent
10-
import android.content.res.Configuration
1110
import android.net.Uri
1211
import android.os.Build
1312
import android.provider.Settings
@@ -19,9 +18,7 @@ import androidx.compose.foundation.layout.Column
1918
import androidx.compose.foundation.layout.WindowInsets
2019
import androidx.compose.foundation.layout.fillMaxSize
2120
import androidx.compose.foundation.layout.fillMaxWidth
22-
import androidx.compose.foundation.layout.navigationBarsPadding
2321
import androidx.compose.foundation.layout.padding
24-
import androidx.compose.foundation.layout.safeContent
2522
import androidx.compose.foundation.layout.size
2623
import androidx.compose.foundation.rememberScrollState
2724
import androidx.compose.foundation.verticalScroll
@@ -66,7 +63,6 @@ import androidx.compose.ui.Alignment
6663
import androidx.compose.ui.Modifier
6764
import androidx.compose.ui.draw.alpha
6865
import androidx.compose.ui.graphics.vector.ImageVector
69-
import androidx.compose.ui.platform.LocalConfiguration
7066
import androidx.compose.ui.platform.LocalContext
7167
import androidx.compose.ui.platform.LocalInspectionMode
7268
import androidx.compose.ui.res.painterResource
@@ -189,7 +185,6 @@ fun AccountsScreen(
189185
}
190186
) {
191187
Scaffold(
192-
contentWindowInsets = WindowInsets.safeContent,
193188
topBar = {
194189
TopAppBar(
195190
navigationIcon = {
@@ -213,15 +208,7 @@ fun AccountsScreen(
213208
)
214209
},
215210
floatingActionButton = {
216-
val conf = LocalConfiguration.current
217-
val isHorizontal = conf.orientation == Configuration.ORIENTATION_LANDSCAPE
218-
Column(
219-
horizontalAlignment = Alignment.CenterHorizontally,
220-
modifier = if (isHorizontal)
221-
Modifier.navigationBarsPadding()
222-
else
223-
Modifier,
224-
) {
211+
Column(horizontalAlignment = Alignment.CenterHorizontally) {
225212
if (showAddAccount == AccountsModel.FABStyle.WithText)
226213
ExtendedFloatingActionButton(
227214
text = { Text(stringResource(R.string.login_add_account)) },

app/src/main/kotlin/at/bitfire/davdroid/ui/AppTheme.kt

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,16 @@ import androidx.activity.SystemBarStyle
88
import androidx.activity.enableEdgeToEdge
99
import androidx.appcompat.app.AppCompatActivity
1010
import androidx.compose.foundation.isSystemInDarkTheme
11+
import androidx.compose.foundation.layout.Box
12+
import androidx.compose.foundation.layout.displayCutoutPadding
13+
import androidx.compose.foundation.layout.fillMaxSize
14+
import androidx.compose.foundation.layout.navigationBarsPadding
1115
import androidx.compose.material3.MaterialTheme
1216
import androidx.compose.runtime.Composable
1317
import androidx.compose.runtime.CompositionLocalProvider
1418
import androidx.compose.runtime.SideEffect
19+
import androidx.compose.ui.Modifier
20+
import androidx.compose.ui.draw.clipToBounds
1521
import androidx.compose.ui.graphics.toArgb
1622
import androidx.compose.ui.platform.LocalContext
1723
import androidx.compose.ui.platform.LocalUriHandler
@@ -44,8 +50,11 @@ fun AppTheme(
4450
M3ColorScheme.lightScheme
4551
else
4652
M3ColorScheme.darkScheme,
47-
content = content
48-
)
53+
) {
54+
Box(Modifier.fillMaxSize().displayCutoutPadding().navigationBarsPadding().clipToBounds()) {
55+
content()
56+
}
57+
}
4958
}
5059

5160
// Track if the app is in the foreground

0 commit comments

Comments
 (0)