Replace PasswordTextField.kt by SecureTextField

[rfc2822]

Seems that there's a Compose password input field in the meanwhile.

We should replace our PasswordTextField composable by the SecureTextField and then it hopefully behaves as expected.

Discussed in #1189

Autocorrection in password field

^{Originally posted by Marcs1987 December 22, 2024}
It seems that spelling correction is activated in the password field in the Add WebDAV mount page. A bad idea I think

[ArnyminerZ]

It was added on Material 3 1.4.0-alpha01, latest stable is 1.3.1. 1.4.0 is still on alpha: 1.4.0-alpha05

[rfc2822]

Ah ok cool, but then I'd say we wait a bit until 1.4.0 is rc or released.

Did you notice whether it turns off autocorrect?

[ArnyminerZ]

Did you notice whether it turns off autocorrect?

I haven't tested it, but if that's really the issue, what actually disconnects autocorrect is the KeyboardOptions, autoCorrectEnabled should be set to false.

We can have a PR now that disables this parameter, and then wait for 1.4.0 for migrating into SecureTextField, which would give some extra benefits such as "some context menu actions like cut, copy, and drag are disabled for added security", though I don't even think this will be useful, since I tend to copy-paste a lot of passwords from my password manager to different apps, when autofill doesn't work correctly.

[rfc2822]

I haven't tested it, but if that's really the issue, what actually disconnects autocorrect is the KeyboardOptions, autoCorrectEnabled should be set to false.

The strange thing is that I thought it should be false by default for keyboard type "password", and we already have keyboard type "password", no?

which would give some extra benefits such as "some context menu actions like cut, copy, and drag are disabled for added security", though I don't even think this will be useful, since I tend to copy-paste a lot of passwords from my password manager to different apps, when autofill doesn't work correctly.

I think it will only disable the possibility to copy passwords out from the field, but not to paste them into the field.

And it's probably not that important that we can't wait for 1.4.0.

[ArnyminerZ]

The strange thing is that I thought it should be false by default for keyboard type "password", and we already have keyboard type "password", no?

According to the docs:

informs the keyboard whether to enable auto correct. Only applicable to text based KeyboardTypes such as KeyboardType.Email, KeyboardType.Uri. It will not be applied to KeyboardTypes such as KeyboardType.Number. Most of keyboard implementations ignore this value for KeyboardTypes such as KeyboardType.Text. A null value (the default parameter value) means autocorrect will be enabled.

So it looks like it depends on the keyboard used.

I think it will only disable the possibility to copy passwords out from the field, but not to paste them into the field.

Makes sense

And it's probably not that important that we can't wait for 1.4.0.

Then let's wait :)

[rfc2822]

Version 1.4.0-alpha06 … waiting

[rfc2822]

Version 1.4.0-alpha07 …

[rfc2822]

alpha08 ……… 🥱

[ArnyminerZ]

Aaaand alpha09...