`TConfig` should have a constraint added to it

[jswalden]

TConfig currently can be anything. But the underlying serialization mechanism, ejson, isn't going to handle everything that's possible. It really ought be constrained to at least what ejson supports to make minimally clear what you can/can't put in a TConfig.

Or, given that TConfig at least initially corresponds to whatever config options the user selects, tho, perhaps it ought be more narrowly { [id: string]: InputValue | undefined }.

[dnmeid]

@jswalden are you good with typescript? For a long time we want to improve the typings but there are some really tricky parts.

[jswalden]

@dnmeid Well...

Literally my only TypeScript experience has come through Companion (or I guess fixing things in other packages in order to do things with Companion). But at this point I'm closing in on two years of doing Companion-related things, including some moderately complicated type manipulations, so I guess "good" probably applies now. 🙂

[Julusian]

It is worth noting that 'soon' we will be dropping ejson and using regular json.

But yeah, the strength of the types is lacking in many places. A large part of this for me is that the code is doing some very js dynamic things, with objects that have not been validated and could contain anything, which makes it hard to do properly.