[BUG] The "Default Export File Name" setting is omitted in configuration exports (and is reset during importing)

[jswalden]

Is this a bug in companion itself or a module?

• I believe this to be a bug in companion

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

The setting to set the default config-export filename isn't saved in those same exports.

That's maybe annoying, but it's not the worst thing in the world on its own.

What makes it much worse is that importing an exported configuration resets that default filename setting. So any time you make a mistake and use your backup to revert, the next time you export you have to set the very thing that was supposed to be a default...which makes the setting itself kind of useless.

I might try to fix this. OTOH last time I tried looking at the export/import code, to try fixing #2688, I got confused by seemingly snarly code in it, so I easily might not, too.

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

Additional context

No response

[jswalden]

So there's plainly some vague idea of including userconfig details (settings) in exports in the code. But it's just commented out -- as if it is believed to be undesirable to include any settings information (including this filename) -- or perhaps more to the point, all of it indiscriminately -- in exports.

companion/webui/src/ImportExport/Export.tsx

Line 26 in 4c58d1d

// userconfig: true,

companion/webui/src/ImportExport/Export.tsx

Line 77 in 4c58d1d

// userconfig: true,

companion/webui/src/ImportExport/Export.tsx

Line 173 in 4c58d1d

{/* <div className="indent3">

It's intentional that UserConfigModel not be saved wholesale in exports or overwritten wholesale in imports. I can easily imagine justification for some of it, for example the HTTPS cert stuff probably at least would demand some opt-in. But I don't have the background to really understand the philosophy the code should embody: which settings would one reasonably want to export, which ones would one want to exclude, what the defaults should be, etc. And without that background, and presuming the undesirability of just bulling ahead to update the export format for exactly one setting, this seems beyond my capacity given my still-meager understanding of the project aims here.

[Julusian]

There is a WIP PR related to this #2875