[BUG] Some hyperlinks to module help pages are not shown

[dnmeid]

Is this a bug in companion itself or a module?

• I believe this to be a bug in companion

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

At various places hyperlinks to module help pages are shown. There seems to be a bug that causes not all of them to show.
In the module management list the help pages for Allen&Heath Avantis and Anlalog Way AWJ are grayed out.

In the add connection list only Avantis is missing.

In the added connection the help is available.

From the avantis module only one version is available, and from AWJ many versions are available but all of them provide a help page.

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS: Win 11
- Browser: Firefox
- Companion Version: 4.0.0+7913-main-a1e84ee0

Additional context

No response

[Julusian]

A very quick look into this:

• that icon for AWJ is working for me
• avantis looks to be a bug in the api not ignoring deprecated versions fully. fix is deploying now

[dnmeid]

Maybe the problem is because the AWJ module I'm using is a dev module in module-local-dev/ ?
Also I just realised that I'm not able to see or add all modules from module-local-dev.
I have a dev version of AWJ and a dev version of a completely unreleased module in that folder which is not known to the store and not added to the config.
During startup I can see in the log that both modules are found:

2025-04-07T08:28:54.317Z info Instance/Modules Found 2 extra modules 
2025-04-07T08:28:54.320Z info Instance/Modules analogway-awj: Analog Way: AWJ Protocol Device; LivePremier; Alta 4K; Midra 4K (Dev) 
2025-04-07T08:28:54.320Z info Instance/Modules analogway-coreplay: Analog Way: CorePlay Solo (Dev)

I can see and add AWJ but not CorePlay (the new module).

And during having a look on this I found some more minor quirks:

• The version selection dropdown in the connection configuration does some weird suffixing. I have a dev version and downloaded a older version from the store. It suffixes the older version as the latest stable, but it is not.
  

• In the change connection type modal modules are shown for individual products but not with the product name, so the entry is just repeated multiple times for each product. Maybe this should be only one entry per module.
  

[Julusian]

the remaining missing help icons should be fixed now. it wasnt handling the case where there was only a dev version

I have a dev version of AWJ and a dev version of a completely unreleased module in that folder which is not known to the store and not added to the config.

Ah yeah, it is failing to show up as it gets filtered out due to having no 'installed' versions. Should be simple enough to unhide it.

The version selection dropdown in the connection configuration does some weird suffixing. I have a dev version and downloaded a older version from the store. It suffixes the older version as the latest stable, but it is not.

Yeah, I'm not 100% happy with the wording currently, so am open to suggestions on how to reword it

[dnmeid]

The version selection dropdown in the connection configuration does some weird suffixing. I have a dev version and downloaded a older version from the store. It suffixes the older version as the latest stable, but it is not.

Yeah, I'm not 100% happy with the wording currently, so am open to suggestions on how to reword it

Well, just don't add a suffix at all in that case.
As far as I remenber our intended logic was this:

let suffix = ''
if (!isDownloaded) suffix += 'Install'
if (!isDownloaded && isLatestVersion) suffix += ' '
if (isLatestVersion) suffix += 'Latest Stable'