[BUG] Font Size unit change from Px to % breaks text/glyphs in module presets (5.0)

[mm2706]

Make sure you're on the latest stable or beta build

• I have tested this on the latest stable or beta release

Is this a bug in companion itself or a module?

• I believe this to be a bug in companion and not a specific module

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Since updating to Companion 5.0, Font Size was changed from Px to percent. The problem: for presets that are defined by modules with a fixed Px size, the conversion doesn't work correctly – the text/glyph is rendered way too large and becomes completely invisible because it overflows the button.
What makes it worse: "Shrink to Fit" is disabled by default, so this doesn't just affect edge cases, it affects basically every impacted preset right after the update. Manually enabling "Shrink to Fit" fixes the display again.
The real issue here: I can't just recreate or adjust the preset myself, since it comes from the module (module-defined preset). So while I can enable "Shrink to Fit" on a per-preset basis, the actual conversion itself needs to be fixed.

Steps To Reproduce

1. Module Preset with glyph ⏵, Font Size 60 (Px)
2. In Companion 4.3: displays normally
3. After updating to 5.0/ Or new Instance on 5.0: Font Size becomes 126 (%), glyph disappears completely
4. Only after manually enabling "Shrink to Fit" or adjusting the size by hand does the glyph show up again

Expected Behavior

The Px to % conversion should render the text at roughly the same visual size as before or "Shrink to Fit" on by Default.

Environment (please complete the following information)

- Companion Version: 5.0-stable
- OS: macOS 26.5.2
- Browser: Safari 26.5.2

Additional context

No response

[Julusian]

I think I need some examples to look at for this. Which module? hopefully I dont need to be connected to anything to get the presets? Alternatively, an exported page from 4.3 and a screenshot of that page will suffice

Throwing together a test module, in 4.3.4 I have:

and 5.0.0:

for some context, 60pt text is the last one that draws the text and it is only doing so when the topbar is hidden

What makes it worse: "Shrink to Fit" is disabled by default, so this doesn't just affect edge cases, it affects basically every impacted preset right after the update. Manually enabling "Shrink to Fit" fixes the display again.

That is intentional. This was added to replace the old 'auto' text size. Before you could choose a specific size or let companion draw it as large as would fit. Now you can choose a maximum draw size, and tell companion it can shrink the text to fit.
So for older presets, we don't want shrink to fit enabled, or that will cause layout differences to before.

[Julusian]

That said, there is no reason for not drawing the text in those blank buttons, having text which gets clipped by its bounds is better than not drawing it. So in 5.0.1 that same test will become:

[Julusian]

Hopefully this is working a lot better in v5.0.2