Skip recently processed nodes in crawler#435
Open
abitofevrything wants to merge 2 commits into
Open
Conversation
mgdigital
reviewed
Jul 1, 2025
| }, | ||
| ignoreNodes: &ignoreFilter{ | ||
| bloom: boom.NewStableBloomFilter(200_000*uint(scalingFactor), 2, 0.001), | ||
| }, |
Collaborator
There was a problem hiding this comment.
I don't think the scaling factor should be used here...
Contributor
Author
There was a problem hiding this comment.
Considering the scaling factor pretty directly affects the number of discovered torrents, having a fixed size filter would mean its effectiveness over time would decrease faster the higher the scaling factor. Having it grow dynamically like this ensures consistent false negative rates (over time, not per torrent count) no matter the scaling factor.
I can run some quick tests to see if this is actually the case, but I would expect it to be.
54 tasks
giorgiobrullo
added a commit
to giorgiobrullo/bitmagnet
that referenced
this pull request
Mar 1, 2026
…nt discovery Cherry-pick of PR bitmagnet-io#435. Replaces the ktable FilterKnownAddrs-based node deduplication with a dedicated ignoreNodes bloom filter. This avoids re-querying recently processed nodes, dramatically increasing the rate of new torrent discovery. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the mechanism used for filtering known nodes to a stable bloom filter, instead of relying on the DHT routing table.