Merge pull request #246 from Bip901/fix/rename-exclusions

Avoid renaming classes that are nested within critical classes, and compiler generated properties/fields

Author: sunnamed434

src/BitMono.Core/Renaming/Renamer.cs

@@ -28,38 +28,52 @@ public string RenameUnsafely()
         var randomStringThree = strings[_randomNext(0, strings.Length - 1)];
         return $"{randomStringTwo} {randomStringOne}.{randomStringThree}";
     }
+
+    private bool ShouldRenameType(TypeDefinition? typeDefinition)
+    {
+        return typeDefinition == null || (_nameCriticalAnalyzer.NotCriticalToMakeChanges(typeDefinition) && !typeDefinition.IsExplicitLayout);
+    }
+
     public void Rename(IMetadataMember member)
     {
         if (member is TypeDefinition type)
         {
-            if (_nameCriticalAnalyzer.NotCriticalToMakeChanges(type))
+            if (ShouldRenameType(type) && ShouldRenameType(type.DeclaringType))
             {
                 type.Name = RenameUnsafely();
             }
         }
         if (member is MethodDefinition method)
         {
-            if (_nameCriticalAnalyzer.NotCriticalToMakeChanges(method))
+            if (_nameCriticalAnalyzer.NotCriticalToMakeChanges(method) && ShouldRenameType(method.DeclaringType))
             {
                 method.Name = RenameUnsafely();
             }
         }
         if (member is FieldDefinition field)
+        {
+            if (!field.IsCompilerGenerated() && ShouldRenameType(field.DeclaringType))
         {
             field.Name = RenameUnsafely();
+            }
         }
         if (member is ParameterDefinition parameter)
+        {
+            if (!parameter.IsCompilerGenerated())
         {
             parameter.Name = RenameUnsafely();
+            }
         }
     }
+
     public void Rename(params IMetadataMember[] members)
     {
         for (var i = 0; i < members.Length; i++)
         {
             Rename(members[i]);
         }
     }
+
     public void RemoveNamespace(IMetadataMember member)
     {
         if (member is TypeDefinition type)
@@ -87,8 +101,9 @@ public void RemoveNamespace(IMetadataMember member)
             }
         }
     }
+
     public void RemoveNamespace(params IMetadataMember[] members)
     {
         members.ForEach(RemoveNamespace);
     }
-}
+}