Use !x instead of x == false

Modernize boolean-negation conditionals across the codebase. Nullable cases
(bool?, e.g. x?.Prop == false) are left as-is since ! doesn't apply to them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: sunnamed434

src/BitMono.CLI/Modules/OptionsObfuscationNeedsFactory.cs

@@ -1,4 +1,4 @@
-namespace BitMono.CLI.Modules;
+namespace BitMono.CLI.Modules;
 
 internal class OptionsObfuscationNeedsFactory
 {
@@ -116,7 +116,7 @@ public OptionsObfuscationNeedsFactory(string[] args)
         // Multiple dependency directories may be passed via -l/--libraries; fall back to the
         // configured (or default "libs") directory when none are given.
         var librariesPaths = options.Libraries
-            .Where(x => string.IsNullOrWhiteSpace(x) == false)
+            .Where(x => !string.IsNullOrWhiteSpace(x))
             .Select(PathFormatterUtility.Format)
             .ToList();
         var referencesDirectories = librariesPaths.Count > 0

src/BitMono.Core/Analyzing/BamlCriticalAnalyzer.cs

@@ -1,4 +1,4 @@
-using BitMono.Core.Analyzing.Baml;
+using BitMono.Core.Analyzing.Baml;
 using BitMono.Core.Services;
 
 namespace BitMono.Core.Analyzing;
@@ -33,13 +33,13 @@ public bool NotCriticalToMakeChanges(IMetadataMember member)
             return true;
         }
         var declaringType = GetDeclaringType(member);
-        return declaringType == null || referencedTypes.Contains(declaringType) == false;
+        return declaringType == null || !referencedTypes.Contains(declaringType);
     }
 
     private HashSet<TypeDefinition> GetReferencedTypes(ModuleDefinition module)
     {
         // Computed once per module (BAML parsing is shared across protections and members).
-        if (ReferenceEquals(_module, module) == false || _referencedTypes == null)
+        if (!ReferenceEquals(_module, module) || _referencedTypes == null)
         {
             _module = module;
             _referencedTypes = WpfBamlReferenceResolver.ResolveReferencedTypes(module);

src/BitMono.Core/Analyzing/CriticalInterfacesCriticalAnalyzer.cs

@@ -11,7 +11,7 @@ public CriticalInterfacesCriticalAnalyzer(CriticalsSettings criticalsSettings)
 
     public bool NotCriticalToMakeChanges(TypeDefinition type)
     {
-        if (_criticalsSettings.UseCriticalInterfaces == false)
+        if (!_criticalsSettings.UseCriticalInterfaces)
         {
             return true;
         }

src/BitMono.Core/Analyzing/CriticalMethodsCriticalAnalyzer.cs

@@ -11,11 +11,11 @@ public CriticalMethodsCriticalAnalyzer(CriticalsSettings criticalsSettings)
 
     public bool NotCriticalToMakeChanges(MethodDefinition method)
     {
-        if (_criticalsSettings.UseCriticalMethods == false)
+        if (!_criticalsSettings.UseCriticalMethods)
         {
             return true;
         }
         var criticalMethodNames = _criticalsSettings.CriticalMethods;
-        return criticalMethodNames.Any(x => x.Equals(method.Name)) == false;
+        return !criticalMethodNames.Any(x => x.Equals(method.Name));
     }
 }

src/BitMono.Core/Analyzing/CriticalMethodsStartsWithAnalyzer.cs

@@ -11,12 +11,12 @@ public CriticalMethodsStartsWithAnalyzer(CriticalsSettings criticalsSettings)
 
     public bool NotCriticalToMakeChanges(MethodDefinition method)
     {
-        if (_criticalsSettings.UseCriticalMethodsStartsWith == false)
+        if (!_criticalsSettings.UseCriticalMethodsStartsWith)
         {
             return true;
         }
 
         var criticalMethodsStartWith = _criticalsSettings.CriticalMethodsStartsWith;
-        return criticalMethodsStartWith.Any(c => c.StartsWith(method.Name)) == false;
+        return !criticalMethodsStartWith.Any(c => c.StartsWith(method.Name));
     }
 }

src/BitMono.Core/Analyzing/ModelAttributeCriticalAnalyzer.cs

@@ -13,7 +13,7 @@ public ModelAttributeCriticalAnalyzer(CriticalsSettings criticalsSettings)
 
     public bool NotCriticalToMakeChanges(IHasCustomAttribute customAttribute)
     {
-        if (_criticalsSettings.UseCriticalModelAttributes == false)
+        if (!_criticalsSettings.UseCriticalModelAttributes)
         {
             return true;
         }

src/BitMono.Core/Analyzing/NameCriticalAnalyzer.cs

@@ -24,23 +24,23 @@ public NameCriticalAnalyzer(
 
     public bool NotCriticalToMakeChanges(TypeDefinition type)
     {
-        if (_criticalInterfacesCriticalAnalyzer.NotCriticalToMakeChanges(type) == false)
+        if (!_criticalInterfacesCriticalAnalyzer.NotCriticalToMakeChanges(type))
         {
             return false;
         }
-        if (_criticalBaseTypesCriticalAnalyzer.NotCriticalToMakeChanges(type) == false)
+        if (!_criticalBaseTypesCriticalAnalyzer.NotCriticalToMakeChanges(type))
         {
             return false;
         }
         return true;
     }
     public bool NotCriticalToMakeChanges(MethodDefinition method)
     {
-        if (_criticalMethodsCriticalAnalyzer.NotCriticalToMakeChanges(method) == false)
+        if (!_criticalMethodsCriticalAnalyzer.NotCriticalToMakeChanges(method))
         {
             return false;
         }
-        if (_criticalMethodsStartsWithAnalyzer.NotCriticalToMakeChanges(method) == false)
+        if (!_criticalMethodsStartsWithAnalyzer.NotCriticalToMakeChanges(method))
         {
             return false;
         }

src/BitMono.Core/Analyzing/RuntimeCriticalAnalyzer.cs

@@ -7,21 +7,21 @@ public bool NotCriticalToMakeChanges(IMetadataMember member)
     {
         if (member is TypeDefinition type)
         {
-            return type.IsRuntimeSpecialName == false;
+            return !type.IsRuntimeSpecialName;
         }
         if (member is FieldDefinition field)
         {
-            return field.IsRuntimeSpecialName == false
-                && field.IsLiteral == false
+            return !field.IsRuntimeSpecialName
+                && !field.IsLiteral
                 && field.DeclaringType?.IsEnum == false;
         }
         if (member is MethodDefinition method)
         {
-            return method.IsRuntimeSpecialName == false || method.DeclaringType?.IsForwarder == false;
+            return !method.IsRuntimeSpecialName || method.DeclaringType?.IsForwarder == false;
         }
         if (member is EventDefinition @event)
         {
-            return @event.IsRuntimeSpecialName == false;
+            return !@event.IsRuntimeSpecialName;
         }
         return true;
     }

src/BitMono.Core/Analyzing/SerializableBitCriticalAnalyzer.cs

@@ -1,4 +1,4 @@
-namespace BitMono.Core.Analyzing;
+namespace BitMono.Core.Analyzing;
 
 [SuppressMessage("ReSharper", "ConvertIfStatementToReturnStatement")]
 public class SerializableBitCriticalAnalyzer : ICriticalAnalyzer<TypeDefinition>
@@ -12,7 +12,7 @@ public SerializableBitCriticalAnalyzer(ObfuscationSettings obfuscationSettings)
 
     public bool NotCriticalToMakeChanges(TypeDefinition type)
     {
-        if (_obfuscationSettings.SerializableBitObfuscationExclude == false)
+        if (!_obfuscationSettings.SerializableBitObfuscationExclude)
         {
             return true;
         }

src/BitMono.Core/Extensions/ProtectionExtensions.cs

@@ -63,7 +63,7 @@ public static string GetName(this Type source, bool inherit = false)
         var protectionNameAttribute = source.GetCustomAttribute<ProtectionNameAttribute>(inherit);
         if (protectionNameAttribute != null)
         {
-            return string.IsNullOrWhiteSpace(protectionNameAttribute.Name) == false
+            return !string.IsNullOrWhiteSpace(protectionNameAttribute.Name)
                 ? protectionNameAttribute.Name
                 : source.Name;
         }