-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[bitnami/external-dns] Add support for --txt-new-format-only #32880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sing the new txt format Signed-off-by: Max Anderson <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the noise, but can you make the suggested change so all parameters are shown together in the readme?
Signed-off-by: Max Anderson <[email protected]>
@jotamartos I've implemented your suggestion. This is ready for your review! |
Signed-off-by: Bitnami Bot <[email protected]>
Bump |
Signed-off-by: Juan José Martos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting after resolving conflicts
Signed-off-by: Bitnami Bot <[email protected]>
Thanks @jotamartos, was there anything else that needed to be done or can this be merged and closed? |
That's all @MaxAnderson95. I accepted the PR but the automation added a new commit after applying the changes so I needed to accept it again. It's now merged. Thanks for your contribution. |
@jotamartos note that this flag does not remove existing records, so when users enable this option they could be left with thousands of stale unmanaged TXT records. You may wish to add a warning to the docs about this. |
Description of the change
This PR adds support for the new
--txt-new-format-only
flag introduced in External DNS v0.16.0 PR #4946Benefits
This allows operators using the TXT registry for storing ownership records, to only need to store a single record. Since the new format was introduced, each
A
/CNAME
record creates two separate ownership records. One in the old format, and one in the new.Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm