Skip to content

[bitnami/external-dns] Add support for --txt-new-format-only #32880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 24, 2025

Conversation

MaxAnderson95
Copy link
Contributor

@MaxAnderson95 MaxAnderson95 commented Apr 9, 2025

Description of the change

This PR adds support for the new --txt-new-format-only flag introduced in External DNS v0.16.0 PR #4946

Benefits

This allows operators using the TXT registry for storing ownership records, to only need to store a single record. Since the new format was introduced, each A/CNAME record creates two separate ownership records. One in the old format, and one in the new.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added external-dns triage Triage is needed labels Apr 9, 2025
@github-actions github-actions bot requested a review from carrodher April 9, 2025 01:38
@MaxAnderson95 MaxAnderson95 marked this pull request as ready for review April 9, 2025 01:43
bitnami-bot and others added 2 commits April 9, 2025 01:48
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Apr 9, 2025
@github-actions github-actions bot removed the triage Triage is needed label Apr 9, 2025
@github-actions github-actions bot removed the request for review from carrodher April 9, 2025 09:18
@github-actions github-actions bot requested a review from jotamartos April 9, 2025 09:18
Signed-off-by: Bitnami Bot <[email protected]>
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the noise, but can you make the suggested change so all parameters are shown together in the readme?

@MaxAnderson95
Copy link
Contributor Author

Sorry for the noise, but can you make the suggested change so all parameters are shown together in the readme?

@jotamartos I've implemented your suggestion. This is ready for your review!

Signed-off-by: Bitnami Bot <[email protected]>
@MaxAnderson95
Copy link
Contributor Author

Bump

Signed-off-by: Juan José Martos <[email protected]>
jotamartos
jotamartos previously approved these changes Apr 23, 2025
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting after resolving conflicts

Signed-off-by: Bitnami Bot <[email protected]>
@MaxAnderson95
Copy link
Contributor Author

Thanks @jotamartos, was there anything else that needed to be done or can this be merged and closed?

@jotamartos jotamartos merged commit ecd3223 into bitnami:main Apr 24, 2025
13 checks passed
@jotamartos
Copy link
Contributor

That's all @MaxAnderson95. I accepted the PR but the automation added a new commit after applying the changes so I needed to accept it again. It's now merged. Thanks for your contribution.

@rouke-broersma
Copy link
Contributor

@jotamartos note that this flag does not remove existing records, so when users enable this option they could be left with thousands of stale unmanaged TXT records. You may wish to add a warning to the docs about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants