Another take

Author: LeoDiazL

operations/deployment/terraform/aws/bitovi_main.tf

@@ -522,13 +522,13 @@ module "aws_route53_ecs" {
   aws_r53_root_domain_deploy    = var.aws_r53_root_domain_deploy
   aws_r53_enable_cert           = var.aws_r53_enable_cert
   # ELB
-  aws_elb_dns_name              = try(module.aws_ecs[0].load_balancer_dns,"")
-  aws_elb_zone_id               = try(module.aws_ecs[0].load_balancer_zone_id,"")
+  aws_elb_dns_name              = module.aws_ecs[0].load_balancer_dns #try(module.aws_ecs[0].load_balancer_dns,"")
+  aws_elb_zone_id               = module.aws_ecs[0].load_balancer_zone_id #try(module.aws_ecs[0].load_balancer_zone_id,"")
   # Certs
   aws_certificates_selected_arn = var.aws_r53_enable_cert && var.aws_r53_domain_name != "" ? module.aws_certificates[0].selected_arn : ""
   # Others
   fqdn_provided                 = local.fqdn_provided
-  depends_on = [ module.aws_certificates,module.aws_ecs ]
+  #depends_on = [ module.aws_certificates,module.aws_ecs ]
   providers = {
     aws = aws.r53
   }

operations/deployment/terraform/modules/aws/route53/aws_route53.tf

@@ -3,39 +3,6 @@ data "aws_route53_zone" "selected" {
   private_zone = false
 }
 
-locals {
-  aws_elb_zone_id = var.aws_elb_zone_id
-}
-
-#data "aws_route53_records" "dev" {
-#  zone_id    = data.aws_route53_zone.selected.zone_id
-#  name_regex = "${var.aws_r53_sub_domain_name}.${var.aws_r53_domain_name}"
-#}
-#
-#resource "aws_route53_record" "dev" {
-#  count   = var.fqdn_provided ? (var.aws_r53_root_domain_deploy ? 0 : 1) : 0
-#  zone_id = data.aws_route53_zone.selected.zone_id
-#  name    = "${var.aws_r53_sub_domain_name}.${var.aws_r53_domain_name}"
-#  type    = "A"
-#
-#  alias {
-#    name                   = var.aws_elb_dns_name
-#    zone_id                = data.aws_route53_records.dev.resource_record_sets.alias_target[0].zone_id != var.aws_elb_zone_id ? var.aws_elb_zone_id : data.aws_route53_records.dev.resource_record_sets.alias_target[0].zone_id
-#     #zone_id                = var.aws_elb_zone_id  # <-- This is different!
-#    evaluate_target_health = true
-#  }
-#}
-
-data "aws_route53_records" "existing_dev" {
-  zone_id    = data.aws_route53_zone.selected.zone_id
-  name_regex = "${var.aws_r53_sub_domain_name}.${var.aws_r53_domain_name}"
-}
-
-# Or if you really need to check existing records, make it safer:
-locals {
-  existing_zone_id = try(data.aws_route53_records.existing_dev.resource_record_sets[0].alias_target.hosted_zone_id) != "" ? data.aws_route53_records.existing_dev.resource_record_sets[0].alias_target.hosted_zone_id : var.aws_elb_zone_id
-}
-
 resource "aws_route53_record" "dev" {
   count   = var.fqdn_provided ? (var.aws_r53_root_domain_deploy ? 0 : 1) : 0
   zone_id = data.aws_route53_zone.selected.zone_id
@@ -44,7 +11,7 @@ resource "aws_route53_record" "dev" {
 
   alias {
     name                   = var.aws_elb_dns_name
-    zone_id                = local.existing_zone_id
+    zone_id                = var.aws_elb_zone_id
     evaluate_target_health = true
   }
 }