Reducing conditionals

Author: LeoDiazL

operations/deployment/terraform/aws/bitovi_main.tf

@@ -176,7 +176,8 @@ module "aws_lb" {
   aws_alb_target_sg_id    = module.ec2[0].aws_security_group_ec2_sg_id
   aws_r53_domain_name     = var.aws_r53_domain_name
   # Certs
-  aws_certificates_selected_arn = var.aws_r53_enable_cert && var.aws_r53_domain_name != "" ? module.aws_certificates[0].selected_arn : ""
+  #aws_certificates_selected_arn = var.aws_r53_enable_cert && var.aws_r53_domain_name != "" ? module.aws_certificates[0].selected_arn : ""
+  aws_certificates_selected_arn = try(module.aws_certificates[0].selected_arn, "")
   # Others
   aws_resource_identifier            = var.aws_resource_identifier
   aws_resource_identifier_supershort = var.aws_resource_identifier_supershort

operations/deployment/terraform/modules/aws/lb/aws_lb.tf

@@ -1,3 +1,22 @@
+# Locals for ALB
+locals {
+  alb_ssl_available = var.aws_certificates_selected_arn != "" ? true : false
+
+  alb_listen_port     = var.aws_alb_listen_port != "" ? [for n in split(",", var.aws_alb_listen_port) : tonumber(n)] : var.aws_certificates_selected_arn != "" ? [443] : [80]
+  alb_listen_protocol = var.aws_alb_listen_protocol != "" ? [for n in split(",", var.aws_alb_listen_protocol) : n] : var.aws_certificates_selected_arn != "" ? ["HTTPS"] : ["HTTP"]
+  alb_app_port        = var.aws_alb_app_port != "" ? [for n in split(",", var.aws_alb_app_port) : tonumber(n)] : local.alb_listen_port
+  alb_app_protocol    = var.aws_alb_app_protocol != "" ? [for n in split(",", var.aws_alb_app_protocol) : n] : [for _ in local.alb_app_port : "HTTP"]
+
+  # Ensure all arrays have the same length
+  alb_ports_ammount = min(
+    length(local.alb_listen_port),
+    length(local.alb_app_port),
+    length(local.alb_listen_protocol),
+    length(local.alb_app_protocol)
+  )
+}
+
+
 # Security group for ALB
 resource "aws_security_group" "alb_security_group" {
   name        = var.aws_alb_security_group_name != "" ? var.aws_alb_security_group_name : "SG for ${var.aws_resource_identifier} - ALB"
@@ -325,24 +344,6 @@ POLICY
   }
 }
 
-# Locals for ALB
-locals {
-  alb_ssl_available = var.aws_certificates_selected_arn != "" ? true : false
-
-  alb_listen_port     = var.aws_alb_listen_port != "" ? [for n in split(",", var.aws_alb_listen_port) : tonumber(n)] : (var.aws_certificates_selected_arn != "" ? [443] : [80])
-  alb_listen_protocol = var.aws_alb_listen_protocol != "" ? [for n in split(",", var.aws_alb_listen_protocol) : n] : (var.aws_certificates_selected_arn != "" ? ["HTTPS"] : ["HTTP"])
-  alb_app_port        = var.aws_alb_app_port != "" ? [for n in split(",", var.aws_alb_app_port) : tonumber(n)] : local.alb_listen_port
-  alb_app_protocol    = var.aws_alb_app_protocol != "" ? [for n in split(",", var.aws_alb_app_protocol) : n] : [for _ in local.alb_app_port : "HTTP"]
-
-  # Ensure all arrays have the same length
-  alb_ports_ammount = min(
-    length(local.alb_listen_port),
-    length(local.alb_app_port),
-    length(local.alb_listen_protocol),
-    length(local.alb_app_protocol)
-  )
-}
-
 # Outputs
 output "aws_alb_dns_name" {
   value = aws_lb.vm_alb.dns_name