Skip to content

Commit a9015c6

Browse files
committed
shotcut cert var
1 parent 3215136 commit a9015c6

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

operations/deployment/terraform/aws/bitovi_main.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,12 +177,13 @@ module "aws_lb" {
177177
aws_r53_domain_name = var.aws_r53_domain_name
178178
# Certs
179179
#aws_certificates_selected_arn = var.aws_r53_enable_cert && var.aws_r53_domain_name != "" ? module.aws_certificates[0].selected_arn : ""
180+
aws_certificate_enabled = var.aws_r53_enable_cert && length(module.aws_certificates) > 0 ? true : false
180181
aws_certificates_selected_arn = try(module.aws_certificates[0].selected_arn, "")
181182
# Others
182183
aws_resource_identifier = var.aws_resource_identifier
183184
aws_resource_identifier_supershort = var.aws_resource_identifier_supershort
184185
# Module dependencies
185-
depends_on = [module.vpc, module.ec2, module.aws_certificates]
186+
#depends_on = [module.vpc, module.ec2, module.aws_certificates]
186187

187188
providers = {
188189
aws = aws.lb

operations/deployment/terraform/modules/aws/lb/aws_lb.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ resource "aws_alb_listener" "lb_listener" {
148148
}
149149

150150
resource "aws_alb_listener" "http_redirect" {
151-
count = var.aws_alb_redirect_enable && var.aws_certificates_selected_arn != "" ? 1 : 0 #!contains(local.alb_listen_port, 80) ? 1 : 0 : 0
151+
count = var.aws_alb_redirect_enable && var.aws_certificate_enabled ? 1 : 0 #!contains(local.alb_listen_port, 80) ? 1 : 0 : 0
152152
load_balancer_arn = aws_lb.vm_alb.arn
153153
port = "80"
154154
protocol = "HTTP"
@@ -169,7 +169,7 @@ resource "aws_alb_listener" "http_redirect" {
169169
}
170170

171171
resource "aws_alb_listener" "http_forward" {
172-
count = var.aws_alb_redirect_enable && !var.aws_alb_www_to_apex_redirect && var.aws_certificates_selected_arn == "" ? 1 : 0 #!contains(local.alb_listen_port, 80) ? 1 : 0 : 0
172+
count = var.aws_alb_redirect_enable && !var.aws_alb_www_to_apex_redirect && !var.aws_certificate_enabled ? 1 : 0 #!contains(local.alb_listen_port, 80) ? 1 : 0 : 0
173173
load_balancer_arn = aws_lb.vm_alb.arn
174174
port = "80"
175175
protocol = "HTTP"
@@ -185,7 +185,7 @@ resource "aws_alb_listener" "http_forward" {
185185
}
186186

187187
resource "aws_alb_listener" "http_www_redirect" {
188-
count = var.aws_alb_redirect_enable && var.aws_alb_www_to_apex_redirect && var.aws_certificates_selected_arn == "" ? 1 : 0 #!contains(local.alb_listen_port, 80) ? 1 : 0 : 0
188+
count = var.aws_alb_redirect_enable && var.aws_alb_www_to_apex_redirect && !var.aws_certificate_enabled ? 1 : 0 #!contains(local.alb_listen_port, 80) ? 1 : 0 : 0
189189
load_balancer_arn = aws_lb.vm_alb.arn
190190
port = "80"
191191
protocol = "HTTP"
@@ -269,7 +269,7 @@ resource "aws_security_group_rule" "incoming_alb_https" {
269269
###
270270

271271
resource "aws_alb_listener" "https_redirect" {
272-
count = var.aws_alb_redirect_enable && var.aws_certificates_selected_arn == "" ? 1 : 0 #!contains(local.alb_listen_port, 443) ? 1 : 0 : 0
272+
count = var.aws_alb_redirect_enable && var.aws_certificate_enabled ? 1 : 0 #!contains(local.alb_listen_port, 443) ? 1 : 0 : 0
273273
load_balancer_arn = aws_lb.vm_alb.arn
274274
port = "443"
275275
protocol = "HTTPS"

operations/deployment/terraform/modules/aws/lb/aws_lb_vars.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ variable "aws_alb_access_log_expire" {}
1818
variable "aws_vpc_selected_id" {}
1919
variable "aws_vpc_subnet_selected" {}
2020
variable "aws_instance_server_id" {}
21+
variable "aws_certificate_enabled" {}
2122
variable "aws_certificates_selected_arn" {}
2223
variable "aws_alb_target_sg_id" {}
2324
variable "aws_r53_domain_name" {}

0 commit comments

Comments
 (0)