Fixing lb output conditionals

Author: LeoDiazL

operations/deployment/terraform/aws/bitovi_main.tf

@@ -533,7 +533,7 @@ module "aws_route53_ecs" {
 
 module "aws_waf_ecs" {
   source = "../modules/aws/waf"
-  count  = var.aws_waf_enable && var.aws_ecs_enable ? 1 : 0
+  count  = var.aws_waf_enable && var.aws_ecs_enable && module.aws_ecs[0].load_balancer_arn != "" ? 1 : 0
   aws_waf_enable             = var.aws_waf_enable
   aws_waf_logging_enable     = var.aws_waf_logging_enable
   aws_waf_log_retention_days = var.aws_waf_log_retention_days

operations/deployment/terraform/modules/aws/ecs/aws_ecs_networking.tf

@@ -229,15 +229,15 @@ resource "aws_security_group_rule" "incoming_ecs_lb_ports" {
 }
 
 output "load_balancer_dns" {
-  value = aws_alb.ecs_lb[0].dns_name
+  value = length(local.aws_ecs_sg_container_port) > 1 ? aws_alb.ecs_lb[0].dns_name : ""
 }
 
 output "load_balancer_port" {
-  value = var.aws_certificate_enabled && length(local.aws_ecs_sg_container_port) > 1 ? aws_alb_listener.lb_listener_ssl[0].port : aws_alb_listener.lb_listener[0].port
+  value = length(local.aws_ecs_sg_container_port) > 1 ? (var.aws_certificate_enabled ? aws_alb_listener.lb_listener_ssl[0].port : aws_alb_listener.lb_listener[0].port) : ""
 }
 
 output "load_balancer_protocol" {
-  value = var.aws_certificate_enabled && length(local.aws_ecs_sg_container_port) > 1 ? aws_alb_listener.lb_listener_ssl[0].protocol : aws_alb_listener.lb_listener[0].protocol
+  value = length(local.aws_ecs_sg_container_port) > 1 ? (var.aws_certificate_enabled ? aws_alb_listener.lb_listener_ssl[0].protocol : aws_alb_listener.lb_listener[0].protocol) : ""
 }
 
 output "load_balancer_zone_id" {