0.5.3 bug-fixing (#129)

* Added missing function
* cleanup
* Commented code cleanup

Author: LeoDiazL

operations/_scripts/deploy/deploy.sh

@@ -32,19 +32,6 @@ export LB_LOGS_BUCKET="$(/bin/bash $GITHUB_ACTION_PATH/operations/_scripts/gener
 # Generate Ansible playbook
 /bin/bash $GITHUB_ACTION_PATH/operations/_scripts/generate/generate_ansible_playbook.sh
 
-# List terraform folder
-echo "ls -al $GITHUB_ACTION_PATH/operations/deployment/terraform/"
-ls -al $GITHUB_ACTION_PATH/operations/deployment/terraform/
-# Prints out bitops.config.yaml
-echo "cat $GITHUB_ACTION_PATH/operations/deployment/terraform/bitops.config.yaml"
-cat $GITHUB_ACTION_PATH/operations/deployment/terraform/bitops.config.yaml
-
-
-echo "cat GITHUB_ACTION_PATH/operations/deployment/terraform/provider.tf"
-cat $GITHUB_ACTION_PATH/operations/deployment/terraform/provider.tf
-echo "ls GITHUB_ACTION_PATH/operations/deployment/ansible/app/${GITHUB_REPO_NAME}"
-ls "$GITHUB_ACTION_PATH/operations/deployment/ansible/app/${GITHUB_REPO_NAME}"
-
 TERRAFORM_COMMAND=""
 TERRAFORM_DESTROY=""
 if [ "$STACK_DESTROY" == "true" ]; then

operations/_scripts/generate/generate_ansible_playbook.sh

@@ -4,6 +4,10 @@ set -e
 
 echo "In generate_ansible_playbook.sh"
 
+function alpha_only() {
+    echo "$1" | tr -cd '[:alpha:]' | tr '[:upper:]' '[:lower:]'
+}
+
 echo -en "- name: Ensure hosts is up and running
   hosts: bitops_servers
   gather_facts: no

operations/_scripts/generate/generate_tf_vars.sh

@@ -92,8 +92,6 @@ aws_postgres_subnets=
 if [ -n "${AWS_POSTGRES_SUBNETS}" ]; then
   aws_postgres_subnets="aws_postgres_subnets = \"$(comma_str_to_tf_array $AWS_POSTGRES_SUBNETS)\""
 fi
-echo "AWS Postgres subnets: $aws_postgres_subnets"
-
 
 #-- Application --#
 app_port=$(generate_var app_port $APP_PORT)

operations/deployment/terraform/elb.tf

@@ -31,11 +31,6 @@ resource "aws_s3_bucket_policy" "allow_access_from_another_account" {
 POLICY
 }
 
-# resource "aws_s3_bucket_acl" "lb_access_logs_acl" {
-#   bucket = aws_s3_bucket.lb_access_logs.id
-#   acl    = "private"
-# }
-
 resource "aws_elb" "vm_ssl" {
   count              = local.cert_available ? 1 : 0
   name               = var.aws_resource_identifier_supershort