Address code review feedback: remove password fields, fix spinner overlap, update tests

Co-authored-by: BitoviAI <[email protected]>

Author: 2 people

app/(dashboard)/tasks/actions.ts

@@ -46,8 +46,8 @@ export async function getAllTasks() {
     try {
         const tasks = await prisma.task.findMany({
             include: {
-                assignee: { select: { id: true, name: true, email: true, password: true } },
-                creator: { select: { id: true, name: true, email: true, password: true } },
+                assignee: { select: { id: true, name: true, email: true } },
+                creator: { select: { id: true, name: true, email: true } },
             },
             orderBy: [
                 { createdAt: "desc" },
@@ -75,8 +75,8 @@ export async function searchTasks(query: string) {
                 ],
             },
             include: {
-                assignee: { select: { id: true, name: true, email: true, password: true } },
-                creator: { select: { id: true, name: true, email: true, password: true } },
+                assignee: { select: { id: true, name: true, email: true } },
+                creator: { select: { id: true, name: true, email: true } },
             },
             orderBy: [
                 { createdAt: "desc" },

components/tasks-page-client.tsx

@@ -112,7 +112,12 @@ export function TasksPageClient({ initialTasks }: TasksPageClientProps) {
             className="pl-9 pr-9"
             data-testid="search-input"
           />
-          {searchQuery && (
+          {isPending && !searchQuery && (
+            <div className="absolute right-3 top-1/2 -translate-y-1/2">
+              <Loader2 className="h-4 w-4 animate-spin text-muted-foreground" data-testid="search-spinner" />
+            </div>
+          )}
+          {searchQuery && !isPending && (
             <button
               onClick={handleClear}
               className="absolute right-3 top-1/2 -translate-y-1/2 text-muted-foreground hover:text-foreground"
@@ -121,9 +126,16 @@ export function TasksPageClient({ initialTasks }: TasksPageClientProps) {
               <X className="h-4 w-4" />
             </button>
           )}
-          {isPending && (
-            <div className="absolute right-3 top-1/2 -translate-y-1/2">
+          {searchQuery && isPending && (
+            <div className="absolute right-3 top-1/2 -translate-y-1/2 flex items-center gap-2">
               <Loader2 className="h-4 w-4 animate-spin text-muted-foreground" data-testid="search-spinner" />
+              <button
+                onClick={handleClear}
+                className="text-muted-foreground hover:text-foreground"
+                data-testid="clear-search"
+              >
+                <X className="h-4 w-4" />
+              </button>
             </div>
           )}
         </div>

tests/e2e/search.spec.ts

@@ -1,7 +1,13 @@
 import { test, expect, Page } from '@playwright/test';
 
+// Test credentials for seeded user
+const TEST_USER = {
+  email: '[email protected]',
+  password: 'password123'
+};
+
 // Helper to log in as a seeded user
-async function login(page: Page, email = '[email protected]', password = 'password123') {
+async function login(page: Page, email = TEST_USER.email, password = TEST_USER.password) {
     await page.goto('/login');
     await page.fill('input#email', email);
     await page.fill('input#password', password);

tests/unit/search-tasks.test.ts

@@ -36,8 +36,8 @@ const mockTasks = [
     updatedAt: new Date(),
     creatorId: 1,
     assigneeId: 1,
-    assignee: { id: 1, name: "John Doe", email: "[email protected]", password: "hashed" },
-    creator: { id: 1, name: "John Doe", email: "[email protected]", password: "hashed" },
+    assignee: { id: 1, name: "John Doe", email: "[email protected]" },
+    creator: { id: 1, name: "John Doe", email: "[email protected]" },
   },
   {
     id: 2,
@@ -50,8 +50,8 @@ const mockTasks = [
     updatedAt: new Date(),
     creatorId: 1,
     assigneeId: 1,
-    assignee: { id: 1, name: "Jane Smith", email: "[email protected]", password: "hashed" },
-    creator: { id: 1, name: "Jane Smith", email: "[email protected]", password: "hashed" },
+    assignee: { id: 1, name: "Jane Smith", email: "[email protected]" },
+    creator: { id: 1, name: "Jane Smith", email: "[email protected]" },
   },
 ]
 
@@ -92,8 +92,8 @@ describe("searchTasks", () => {
         ],
       },
       include: {
-        assignee: { select: { id: true, name: true, email: true, password: true } },
-        creator: { select: { id: true, name: true, email: true, password: true } },
+        assignee: { select: { id: true, name: true, email: true } },
+        creator: { select: { id: true, name: true, email: true } },
       },
       orderBy: [
         { createdAt: "desc" },