Resolve review feedback

Author: Hinton

apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.ts

@@ -218,7 +218,6 @@ export class MemberDialogComponent implements OnDestroy {
       groups: groups$,
       flexibleCollectionsV1Enabled: this.configService.getFeatureFlag$(
         FeatureFlag.FlexibleCollectionsV1,
-        false,
       ),
     })
       .pipe(takeUntil(this.destroy$))

bitwarden_license/bit-web/src/app/admin-console/providers/settings/account.component.ts

@@ -30,7 +30,6 @@ export class AccountComponent {
 
   protected enableDeleteProvider$ = this.configService.getFeatureFlag$(
     FeatureFlag.EnableDeleteProvider,
-    false,
   );
 
   constructor(

bitwarden_license/bit-web/src/app/admin-console/providers/setup/setup.component.ts

@@ -40,7 +40,6 @@ export class SetupComponent implements OnInit {
 
   protected enableConsolidatedBilling$ = this.configService.getFeatureFlag$(
     FeatureFlag.EnableConsolidatedBilling,
-    false,
   );
 
   constructor(

libs/common/src/enums/feature-flag.enum.ts

@@ -1,3 +1,8 @@
+/**
+ * Feature flags.
+ *
+ * Flags MUST be short lived and SHALL be removed once enabled.
+ */
 export enum FeatureFlag {
   BrowserFilelessImport = "browser-fileless-import",
   ItemShare = "item-share",
@@ -21,7 +26,8 @@ const FALSE = false as boolean;
 /**
  * Default value for feature flags.
  *
- * Flags MUST be short lived and SHALL be removed once enabled.
+ * DO NOT enable previously disabled flags, REMOVE them instead.
+ * We support true as a value as we prefer flags to "enable" not "disable".
  */
 export const DefaultFeatureFlagValue = {
   [FeatureFlag.BrowserFilelessImport]: FALSE,
@@ -34,8 +40,10 @@ export const DefaultFeatureFlagValue = {
   [FeatureFlag.ShowPaymentMethodWarningBanners]: FALSE,
   [FeatureFlag.EnableConsolidatedBilling]: FALSE,
   [FeatureFlag.AC1795_UpdatedSubscriptionStatusSection]: FALSE,
+  [FeatureFlag.UnassignedItemsBanner]: FALSE,
+  [FeatureFlag.EnableDeleteProvider]: FALSE,
 } satisfies Record<FeatureFlag, AllowedFeatureFlagTypes>;
 
 export type DefaultFeatureFlagValueType = typeof DefaultFeatureFlagValue;
 
-export type FeatureFlagType<Flag extends FeatureFlag> = DefaultFeatureFlagValueType[Flag];
+export type FeatureFlagValueType<Flag extends FeatureFlag> = DefaultFeatureFlagValueType[Flag];

libs/common/src/platform/abstractions/config/config.service.ts

@@ -1,7 +1,7 @@
 import { Observable } from "rxjs";
 import { SemVer } from "semver";
 
-import { FeatureFlag, FeatureFlagType } from "../../../enums/feature-flag.enum";
+import { FeatureFlag, FeatureFlagValueType } from "../../../enums/feature-flag.enum";
 import { Region } from "../environment.service";
 
 import { ServerConfig } from "./server-config";
@@ -14,17 +14,15 @@ export abstract class ConfigService {
   /**
    * Retrieves the value of a feature flag for the currently active user
    * @param key The feature flag to retrieve
-   * @param defaultValue The default value to return if the feature flag is not set or the server's config is irretrievable
    * @returns An observable that emits the value of the feature flag, updates as the server config changes
    */
-  getFeatureFlag$: <Flag extends FeatureFlag>(key: Flag) => Observable<FeatureFlagType<Flag>>;
+  getFeatureFlag$: <Flag extends FeatureFlag>(key: Flag) => Observable<FeatureFlagValueType<Flag>>;
   /**
    * Retrieves the value of a feature flag for the currently active user
    * @param key The feature flag to retrieve
-   * @param defaultValue The default value to return if the feature flag is not set or the server's config is irretrievable
    * @returns The value of the feature flag
    */
-  getFeatureFlag: <Flag extends FeatureFlag>(key: Flag) => Promise<FeatureFlagType<Flag>>;
+  getFeatureFlag: <Flag extends FeatureFlag>(key: Flag) => Promise<FeatureFlagValueType<Flag>>;
   /**
    * Verifies whether the server version meets the minimum required version
    * @param minimumRequiredServerVersion The minimum version required

libs/common/src/platform/services/config/default-config.service.ts

@@ -16,7 +16,7 @@ import { SemVer } from "semver";
 import {
   DefaultFeatureFlagValue,
   FeatureFlag,
-  FeatureFlagType,
+  FeatureFlagValueType,
 } from "../../../enums/feature-flag.enum";
 import { UserId } from "../../../types/guid";
 import { ConfigApiServiceAbstraction } from "../../abstractions/config/config-api.service.abstraction";
@@ -101,7 +101,7 @@ export class DefaultConfigService implements ConfigService {
           return DefaultFeatureFlagValue[key];
         }
 
-        return serverConfig.featureStates[key] as FeatureFlagType<Flag>;
+        return serverConfig.featureStates[key] as FeatureFlagValueType<Flag>;
       }),
     );
   }