[PM-39153] chore: Fix trivial warnings (#2800)

Author: fedemkr

AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListView.swift

@@ -276,7 +276,11 @@ private struct SearchableItemListView: View { // swiftlint:disable:this type_bod
     private func groupView(title: String?, items: [ItemListItem]) -> some View {
         LazyVStack(alignment: .leading, spacing: 7) {
             if let title = title?.nilIfEmpty {
-                ExpandableHeaderView(title: title, count: items.count, buttonAccessibilityIdentifier: title+"Header") {
+                ExpandableHeaderView(
+                    title: title,
+                    count: items.count,
+                    buttonAccessibilityIdentifier: title + "Header",
+                ) {
                     ForEach(items) { item in
                         buildRow(item: item, isLastInSection: true)
                             .clipShape(RoundedRectangle(cornerRadius: 10))

BitwardenShared/Core/Platform/Services/ClientService.swift

@@ -326,7 +326,7 @@ actor DefaultClientService: ClientService {
     /// - Parameter config: Config to update the flags.
     private func loadFlags(_ config: ServerConfig?, for client: BitwardenSdkClient) async {
         do {
-            guard let config else {
+            guard config != nil else {
                 return
             }
 

BitwardenShared/UI/Billing/PremiumPlan/PremiumPlanProcessor.swift

@@ -130,11 +130,10 @@ final class PremiumPlanProcessor: StateProcessor<
                 )
                 return
             }
-            let subscription: PremiumSubscription
-            if let existing = state.subscription {
-                subscription = existing
+            let subscription: PremiumSubscription = if let existing = state.subscription {
+                existing
             } else {
-                subscription = try await services.billingService.getSubscription()
+                try await services.billingService.getSubscription()
             }
             state.subscription = subscription
             state.planStatus = subscription.status

BitwardenShared/UI/Tools/Generator/Generator/GeneratorProcessor.swift

@@ -87,7 +87,8 @@ final class GeneratorProcessor: StateProcessor<GeneratorState, GeneratorAction,
             await reloadGeneratorOptions()
             await generateValue(shouldSavePassword: true)
             await checkLearnGeneratorActionCardEligibility()
-            state.shouldShowUpgradedToPremiumActionCard = await services.billingService.shouldShowUpgradedToPremiumActionCard()
+            state.shouldShowUpgradedToPremiumActionCard = await services.billingService
+                .shouldShowUpgradedToPremiumActionCard()
         case .dismissLearnGeneratorActionCard:
             await services.stateService.setLearnGeneratorActionCardStatus(.complete)
             state.isLearnGeneratorActionCardEligible = false

BitwardenShared/UI/Tools/Send/Send/SendList/SendListProcessor.swift

@@ -61,7 +61,8 @@ final class SendListProcessor: StateProcessor<SendListState, SendListAction, Sen
         case let .addItemPressed(sendType):
             await addNewSend(sendType: sendType)
         case .appeared:
-            state.shouldShowUpgradedToPremiumActionCard = await services.billingService.shouldShowUpgradedToPremiumActionCard()
+            state.shouldShowUpgradedToPremiumActionCard = await services.billingService
+                .shouldShowUpgradedToPremiumActionCard()
         case .dismissUpgradedToPremiumActionCard:
             state.shouldShowUpgradedToPremiumActionCard = false
             await services.billingService.setUpgradedToPremiumActionCardDismissed()

BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessor.swift

@@ -238,7 +238,8 @@ extension VaultListProcessor {
 
         state.shouldShowArchiveOnboardingActionCard = await services.stateService.shouldDoArchiveOnboarding()
 
-        state.shouldShowUpgradedToPremiumActionCard = await services.billingService.shouldShowUpgradedToPremiumActionCard()
+        state.shouldShowUpgradedToPremiumActionCard = await services.billingService
+            .shouldShowUpgradedToPremiumActionCard()
 
         let isBannerDismissed = await services.stateService.isPremiumUpgradeBannerDismissed()
         guard !isBannerDismissed else {