Add type-safety for passport and drivers license dates

david-livefront · david-livefront · commit fbfb3e5bba55 · 2026-07-01T17:01:10.000-05:00
diff --git a/crates/bitwarden-core/uniffi.toml b/crates/bitwarden-core/uniffi.toml
@@ -16,3 +16,27 @@ ffi_module_name = "BitwardenCoreFFI"
 module_name = "BitwardenCore"
 generate_immutable_records = true
 generate_codable_conformance = true
+
+[bindings.swift.custom_types.NaiveDate]
+type_name = "Date"
+imports = ["Foundation"]
+into_custom = """
+{
+    let formatter = DateFormatter()
+    formatter.locale = Locale(identifier: "en_US_POSIX")
+    formatter.timeZone = TimeZone(identifier: "UTC")
+    formatter.dateFormat = "yyyy-MM-dd"
+    formatter.isLenient = false
+    return formatter.date(from: {})
+}()
+"""
+from_custom = """
+{
+    let formatter = DateFormatter()
+    formatter.locale = Locale(identifier: "en_US_POSIX")
+    formatter.timeZone = TimeZone(identifier: "UTC")
+    formatter.dateFormat = "yyyy-MM-dd"
+    formatter.isLenient = false
+    return formatter.string(from: {})
+}()
+"""
diff --git a/crates/bitwarden-vault/src/cipher/blob/conversions/drivers_license.rs b/crates/bitwarden-vault/src/cipher/blob/conversions/drivers_license.rs
@@ -1,22 +1,40 @@
 use super::{DriversLicenseDataV1, DriversLicenseView};
 
-impl_bidirectional_from!(
-    DriversLicenseView,
-    DriversLicenseDataV1,
-    [
-        first_name,
-        middle_name,
-        last_name,
-        date_of_birth,
-        license_number,
-        issuing_country,
-        issuing_state,
-        issue_date,
-        expiration_date,
-        issuing_authority,
-        license_class,
-    ]
-);
+impl From<&DriversLicenseView> for DriversLicenseDataV1 {
+    fn from(src: &DriversLicenseView) -> Self {
+        Self {
+            first_name: src.first_name.clone(),
+            middle_name: src.middle_name.clone(),
+            last_name: src.last_name.clone(),
+            date_of_birth: src.date_of_birth.map(|d| d.to_string()),
+            license_number: src.license_number.clone(),
+            issuing_country: src.issuing_country.clone(),
+            issuing_state: src.issuing_state.clone(),
+            issue_date: src.issue_date.map(|d| d.to_string()),
+            expiration_date: src.expiration_date.map(|d| d.to_string()),
+            issuing_authority: src.issuing_authority.clone(),
+            license_class: src.license_class.clone(),
+        }
+    }
+}
+
+impl From<&DriversLicenseDataV1> for DriversLicenseView {
+    fn from(src: &DriversLicenseDataV1) -> Self {
+        Self {
+            first_name: src.first_name.clone(),
+            middle_name: src.middle_name.clone(),
+            last_name: src.last_name.clone(),
+            date_of_birth: src.date_of_birth.as_deref().and_then(|s| s.parse().ok()),
+            license_number: src.license_number.clone(),
+            issuing_country: src.issuing_country.clone(),
+            issuing_state: src.issuing_state.clone(),
+            issue_date: src.issue_date.as_deref().and_then(|s| s.parse().ok()),
+            expiration_date: src.expiration_date.as_deref().and_then(|s| s.parse().ok()),
+            issuing_authority: src.issuing_authority.clone(),
+            license_class: src.license_class.clone(),
+        }
+    }
+}
 
 #[cfg(test)]
 mod tests {
@@ -36,12 +54,12 @@ mod tests {
                 first_name: Some("John".to_string()),
                 middle_name: Some("Michael".to_string()),
                 last_name: Some("Doe".to_string()),
-                date_of_birth: Some("1985-06-15".to_string()),
+                date_of_birth: chrono::NaiveDate::from_ymd_opt(1985, 6, 15),
                 license_number: Some("DL-987654".to_string()),
                 issuing_country: Some("US".to_string()),
                 issuing_state: Some("NY".to_string()),
-                issue_date: Some("2020-01-01".to_string()),
-                expiration_date: Some("2028-01-01".to_string()),
+                issue_date: chrono::NaiveDate::from_ymd_opt(2020, 1, 1),
+                expiration_date: chrono::NaiveDate::from_ymd_opt(2028, 1, 1),
                 issuing_authority: Some("NY DMV".to_string()),
                 license_class: Some("D".to_string()),
             }),
diff --git a/crates/bitwarden-vault/src/cipher/blob/conversions/passport.rs b/crates/bitwarden-vault/src/cipher/blob/conversions/passport.rs
@@ -1,24 +1,44 @@
 use super::{PassportDataV1, PassportView};
 
-impl_bidirectional_from!(
-    PassportView,
-    PassportDataV1,
-    [
-        surname,
-        given_name,
-        date_of_birth,
-        sex,
-        birth_place,
-        nationality,
-        issuing_country,
-        passport_number,
-        passport_type,
-        national_identification_number,
-        issuing_authority,
-        issue_date,
-        expiration_date,
-    ]
-);
+impl From<&PassportView> for PassportDataV1 {
+    fn from(src: &PassportView) -> Self {
+        Self {
+            surname: src.surname.clone(),
+            given_name: src.given_name.clone(),
+            date_of_birth: src.date_of_birth.map(|d| d.to_string()),
+            sex: src.sex.clone(),
+            birth_place: src.birth_place.clone(),
+            nationality: src.nationality.clone(),
+            issuing_country: src.issuing_country.clone(),
+            passport_number: src.passport_number.clone(),
+            passport_type: src.passport_type.clone(),
+            national_identification_number: src.national_identification_number.clone(),
+            issuing_authority: src.issuing_authority.clone(),
+            issue_date: src.issue_date.map(|d| d.to_string()),
+            expiration_date: src.expiration_date.map(|d| d.to_string()),
+        }
+    }
+}
+
+impl From<&PassportDataV1> for PassportView {
+    fn from(src: &PassportDataV1) -> Self {
+        Self {
+            surname: src.surname.clone(),
+            given_name: src.given_name.clone(),
+            date_of_birth: src.date_of_birth.as_deref().and_then(|s| s.parse().ok()),
+            sex: src.sex.clone(),
+            birth_place: src.birth_place.clone(),
+            nationality: src.nationality.clone(),
+            issuing_country: src.issuing_country.clone(),
+            passport_number: src.passport_number.clone(),
+            passport_type: src.passport_type.clone(),
+            national_identification_number: src.national_identification_number.clone(),
+            issuing_authority: src.issuing_authority.clone(),
+            issue_date: src.issue_date.as_deref().and_then(|s| s.parse().ok()),
+            expiration_date: src.expiration_date.as_deref().and_then(|s| s.parse().ok()),
+        }
+    }
+}
 
 #[cfg(test)]
 mod tests {
@@ -37,7 +57,7 @@ mod tests {
             passport: Some(PassportView {
                 surname: Some("Doe".to_string()),
                 given_name: Some("Jane".to_string()),
-                date_of_birth: Some("1990-01-01".to_string()),
+                date_of_birth: chrono::NaiveDate::from_ymd_opt(1990, 1, 1),
                 sex: Some("F".to_string()),
                 birth_place: Some("New York".to_string()),
                 nationality: Some("American".to_string()),
@@ -46,8 +66,8 @@ mod tests {
                 passport_type: Some("P".to_string()),
                 national_identification_number: Some("123-45-6789".to_string()),
                 issuing_authority: Some("US State Department".to_string()),
-                issue_date: Some("2020-01-01".to_string()),
-                expiration_date: Some("2030-01-01".to_string()),
+                issue_date: chrono::NaiveDate::from_ymd_opt(2020, 1, 1),
+                expiration_date: chrono::NaiveDate::from_ymd_opt(2030, 1, 1),
             }),
             ..create_shell_cipher_view(CipherType::Passport)
         };
diff --git a/crates/bitwarden-vault/src/cipher/cipher.rs b/crates/bitwarden-vault/src/cipher/cipher.rs
@@ -3488,7 +3488,7 @@ mod tests {
         let passport = passport::PassportView {
             given_name: Some("Jane".to_string()),
             surname: Some("Doe".to_string()),
-            date_of_birth: Some("1990-01-01".to_string()),
+            date_of_birth: chrono::NaiveDate::from_ymd_opt(1990, 1, 1),
             sex: Some("F".to_string()),
             birth_place: Some("New York".to_string()),
             nationality: Some("American".to_string()),
@@ -3497,8 +3497,8 @@ mod tests {
             passport_type: Some("P".to_string()),
             national_identification_number: Some("123-45-6789".to_string()),
             issuing_authority: Some("US State Department".to_string()),
-            issue_date: Some("2020-01-01".to_string()),
-            expiration_date: Some("2030-01-01".to_string()),
+            issue_date: chrono::NaiveDate::from_ymd_opt(2020, 1, 1),
+            expiration_date: chrono::NaiveDate::from_ymd_opt(2030, 1, 1),
         };
 
         let cipher_view = CipherView {
@@ -3526,12 +3526,12 @@ mod tests {
             first_name: Some("John".to_string()),
             middle_name: Some("Michael".to_string()),
             last_name: Some("Doe".to_string()),
-            date_of_birth: Some("1985-06-15".to_string()),
+            date_of_birth: chrono::NaiveDate::from_ymd_opt(1985, 6, 15),
             license_number: Some("DL-987654".to_string()),
             issuing_country: Some("US".to_string()),
             issuing_state: Some("NY".to_string()),
-            issue_date: Some("2020-01-01".to_string()),
-            expiration_date: Some("2028-01-01".to_string()),
+            issue_date: chrono::NaiveDate::from_ymd_opt(2020, 1, 1),
+            expiration_date: chrono::NaiveDate::from_ymd_opt(2028, 1, 1),
             issuing_authority: Some("NY DMV".to_string()),
             license_class: Some("D".to_string()),
         };
diff --git a/crates/bitwarden-vault/src/cipher/drivers_license.rs b/crates/bitwarden-vault/src/cipher/drivers_license.rs
@@ -4,6 +4,7 @@ use bitwarden_crypto::{
     CompositeEncryptable, CryptoError, Decryptable, EncString, KeyStoreContext,
     PrimitiveEncryptable,
 };
+use chrono::NaiveDate;
 use serde::{Deserialize, Serialize};
 #[cfg(feature = "wasm")]
 use tsify::Tsify;
@@ -38,12 +39,12 @@ pub struct DriversLicenseView {
     pub first_name: Option<String>,
     pub middle_name: Option<String>,
     pub last_name: Option<String>,
-    pub date_of_birth: Option<String>,
+    pub date_of_birth: Option<NaiveDate>,
     pub license_number: Option<String>,
     pub issuing_country: Option<String>,
     pub issuing_state: Option<String>,
-    pub issue_date: Option<String>,
-    pub expiration_date: Option<String>,
+    pub issue_date: Option<NaiveDate>,
+    pub expiration_date: Option<NaiveDate>,
     pub issuing_authority: Option<String>,
     pub license_class: Option<String>,
 }
@@ -58,12 +59,18 @@ impl CompositeEncryptable<KeySlotIds, SymmetricKeySlotId, DriversLicense> for Dr
             first_name: self.first_name.encrypt(ctx, key)?,
             middle_name: self.middle_name.encrypt(ctx, key)?,
             last_name: self.last_name.encrypt(ctx, key)?,
-            date_of_birth: self.date_of_birth.encrypt(ctx, key)?,
+            date_of_birth: self
+                .date_of_birth
+                .map(|d| d.to_string())
+                .encrypt(ctx, key)?,
             license_number: self.license_number.encrypt(ctx, key)?,
             issuing_country: self.issuing_country.encrypt(ctx, key)?,
             issuing_state: self.issuing_state.encrypt(ctx, key)?,
-            issue_date: self.issue_date.encrypt(ctx, key)?,
-            expiration_date: self.expiration_date.encrypt(ctx, key)?,
+            issue_date: self.issue_date.map(|d| d.to_string()).encrypt(ctx, key)?,
+            expiration_date: self
+                .expiration_date
+                .map(|d| d.to_string())
+                .encrypt(ctx, key)?,
             issuing_authority: self.issuing_authority.encrypt(ctx, key)?,
             license_class: self.license_class.encrypt(ctx, key)?,
         })
@@ -80,12 +87,27 @@ impl Decryptable<KeySlotIds, SymmetricKeySlotId, DriversLicenseView> for Drivers
             first_name: self.first_name.decrypt(ctx, key).ok().flatten(),
             middle_name: self.middle_name.decrypt(ctx, key).ok().flatten(),
             last_name: self.last_name.decrypt(ctx, key).ok().flatten(),
-            date_of_birth: self.date_of_birth.decrypt(ctx, key).ok().flatten(),
+            date_of_birth: self
+                .date_of_birth
+                .decrypt(ctx, key)
+                .ok()
+                .flatten()
+                .and_then(|s: String| s.parse().ok()),
             license_number: self.license_number.decrypt(ctx, key).ok().flatten(),
             issuing_country: self.issuing_country.decrypt(ctx, key).ok().flatten(),
             issuing_state: self.issuing_state.decrypt(ctx, key).ok().flatten(),
-            issue_date: self.issue_date.decrypt(ctx, key).ok().flatten(),
-            expiration_date: self.expiration_date.decrypt(ctx, key).ok().flatten(),
+            issue_date: self
+                .issue_date
+                .decrypt(ctx, key)
+                .ok()
+                .flatten()
+                .and_then(|s: String| s.parse().ok()),
+            expiration_date: self
+                .expiration_date
+                .decrypt(ctx, key)
+                .ok()
+                .flatten()
+                .and_then(|s: String| s.parse().ok()),
             issuing_authority: self.issuing_authority.decrypt(ctx, key).ok().flatten(),
             license_class: self.license_class.decrypt(ctx, key).ok().flatten(),
         })
@@ -200,12 +222,12 @@ mod tests {
             first_name: Some("John".to_string()),
             middle_name: Some("Michael".to_string()),
             last_name: Some("Doe".to_string()),
-            date_of_birth: Some("1985-06-15".to_string()),
+            date_of_birth: NaiveDate::from_ymd_opt(1985, 6, 15),
             license_number: Some("DL-987654".to_string()),
             issuing_country: Some("US".to_string()),
             issuing_state: Some("NY".to_string()),
-            issue_date: Some("2020-01-01".to_string()),
-            expiration_date: Some("2028-01-01".to_string()),
+            issue_date: NaiveDate::from_ymd_opt(2020, 1, 1),
+            expiration_date: NaiveDate::from_ymd_opt(2028, 1, 1),
             issuing_authority: Some("NY DMV".to_string()),
             license_class: Some("D".to_string()),
         }
diff --git a/crates/bitwarden-vault/src/cipher/passport.rs b/crates/bitwarden-vault/src/cipher/passport.rs
diff --git a/crates/bitwarden-wasm-internal/src/custom_types.rs b/crates/bitwarden-wasm-internal/src/custom_types.rs
