Commit 6643428
refactor: remove automated CHANGELOG commits for security
Based on security research, allowing github-actions bot to bypass branch
protection creates attack vectors for malicious workflows. Following best
practices from Google's release-please and industry standards, CHANGELOG.md
is now manually maintained.
Changes:
- Remove CHANGELOG auto-update and commit steps from workflow
- Add verification step to check CHANGELOG was updated
- Update documentation to reflect manual process
- Simplifies workflow and eliminates branch protection conflicts
Security benefits:
- No bypass permissions needed (eliminates attack surface)
- Manual review ensures quality release notes
- Follows GitHub security best practices
- Matches workflow used by major OSS projects
References:
- https://medium.com/cider-sec/bypassing-required-reviews-using-github-actions-6e1b29135cc7
- https://github.com/googleapis/release-please-action
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>1 parent 5e1539f commit 6643428
3 files changed
Lines changed: 19 additions & 49 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | 84 | | |
118 | | - | |
119 | | - | |
120 | | - | |
| 85 | + | |
121 | 86 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
126 | 97 | | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | | - | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
49 | | - | |
50 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
51 | 54 | | |
52 | 55 | | |
53 | 56 | | |
| |||
0 commit comments