resolve trigger endpoint vars from environment (#24)

Author: bivas

engine/actions/trigger/trigger.go

@@ -3,6 +3,7 @@ package trigger
 import (
 	"fmt"
 	"net/http"
+	"os"
 	"strings"
 	"time"
 
@@ -56,7 +57,7 @@ func (a *action) prepareRequest(meta types.Data) *http.Request {
 		Origin: meta.GetOrigin(),
 	}
 	body := processMessage(&a.rule.Body, message)
-	request, e := http.NewRequest(a.rule.Method, a.rule.Endpoint, body)
+	request, e := http.NewRequest(a.rule.Method, os.ExpandEnv(a.rule.Endpoint), body)
 	if e != nil {
 		a.logger.ErrorWith(log.MetaFields{log.F("issue", meta.GetShortName()), log.E(e)},
 			"Error trying to build trigger request", e)

engine/actions/trigger/trigger_test.go

@@ -2,6 +2,7 @@ package trigger
 
 import (
 	"net/http"
+	"os"
 	"testing"
 
 	"github.com/bivas/rivi/mocks"
@@ -119,3 +120,33 @@ func TestTriggerHeaders(t *testing.T) {
 	action.Apply(state.New(&mocks.MockConfiguration{}, meta))
 	assert.Nil(t, action.err, "error when sending trigger")
 }
+
+func TestEnvironmentEndpoint(t *testing.T) {
+	httpmock.Activate()
+	defer httpmock.DeactivateAndReset()
+	meta := &mocks.MockData{
+		Number: 1,
+		Title:  "title1",
+		State:  "tested",
+		Owner:  "test",
+		Repo:   "repo1",
+		Origin: types.Origin{User: "tester"},
+	}
+	os.Setenv("MOCK_HOST", "mock")
+	os.Setenv("MOCK_PORT", "1111")
+	rule := &rule{
+		Endpoint: "http://${MOCK_HOST}:${MOCK_PORT}/trigger",
+	}
+	rule.Defaults()
+	httpmock.RegisterResponder(
+		"POST",
+		"http://mock:1111/trigger",
+		func(req *http.Request) (*http.Response, error) {
+			assert.Equal(t, "trigger", req.Header.Get("X-Rivi-Event"), "missing correct event")
+			assert.Equal(t, "Rivi-Agent/1.0", req.UserAgent(), "user agent")
+			return httpmock.NewStringResponse(200, ""), nil
+		})
+	action := &action{rule: rule, client: http.DefaultClient, logger: log.Get("trigger.test")}
+	action.Apply(state.New(&mocks.MockConfiguration{}, meta))
+	assert.Nil(t, action.err, "error when sending trigger")
+}