try to fix windows build

Author: bjartek

pkg/frontend/manager.go

@@ -2,16 +2,13 @@ package frontend
 
 import (
 	"bufio"
-	"errors"
 	"fmt"
 	"io"
 	"os"
 	"os/exec"
-	"runtime"
 	"sort"
 	"strings"
 	"sync"
-	"syscall"
 	"time"
 
 	"github.com/bjartek/aether/pkg/events"
@@ -90,9 +87,7 @@ func (m *FrontendManager) Start(teaProgram *tea.Program) error {
 	}
 
 	cmd := exec.Command(parts[0], parts[1:]...)
-	if runtime.GOOS != "windows" {
-		cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
-	}
+	setupProcessGroup(cmd)
 
 	if wd, err := os.Getwd(); err != nil {
 		m.logger.Warn().Err(err).Msg("Failed to get working directory for frontend process; using shell default")
@@ -245,30 +240,7 @@ func (m *FrontendManager) Stop() error {
 	}
 
 	m.logger.Info().Msg("Stopping frontend process")
-	var err error
-
-	if runtime.GOOS == "windows" {
-		err = m.cmd.Process.Kill()
-	} else {
-		pgid, pgErr := syscall.Getpgid(m.cmd.Process.Pid)
-		if pgErr != nil {
-			err = m.cmd.Process.Kill()
-		} else {
-			// Attempt graceful shutdown
-			termErr := syscall.Kill(-pgid, syscall.SIGTERM)
-			if termErr != nil && !errors.Is(termErr, syscall.ESRCH) {
-				err = termErr
-			}
-
-			// Give process a brief moment to exit before forcing
-			time.Sleep(250 * time.Millisecond)
-
-			killErr := syscall.Kill(-pgid, syscall.SIGKILL)
-			if killErr != nil && !errors.Is(killErr, syscall.ESRCH) {
-				err = killErr
-			}
-		}
-	}
+	err := stopProcess(m.cmd)
 
 	if err != nil {
 		m.logger.Error().Err(err).Msg("Failed to stop frontend process")

pkg/frontend/manager_unix.go

@@ -0,0 +1,44 @@
+//go:build !windows
+
+package frontend
+
+import (
+	"errors"
+	"os/exec"
+	"syscall"
+	"time"
+)
+
+// setupProcessGroup configures the command to run in its own process group
+func setupProcessGroup(cmd *exec.Cmd) {
+	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+}
+
+// stopProcess stops the process and its children gracefully on Unix systems
+func stopProcess(cmd *exec.Cmd) error {
+	if cmd == nil || cmd.Process == nil {
+		return nil
+	}
+
+	pgid, pgErr := syscall.Getpgid(cmd.Process.Pid)
+	if pgErr != nil {
+		return cmd.Process.Kill()
+	}
+
+	// Attempt graceful shutdown with SIGTERM
+	termErr := syscall.Kill(-pgid, syscall.SIGTERM)
+	if termErr != nil && !errors.Is(termErr, syscall.ESRCH) {
+		return termErr
+	}
+
+	// Give process a brief moment to exit before forcing
+	time.Sleep(250 * time.Millisecond)
+
+	// Force kill with SIGKILL
+	killErr := syscall.Kill(-pgid, syscall.SIGKILL)
+	if killErr != nil && !errors.Is(killErr, syscall.ESRCH) {
+		return killErr
+	}
+
+	return nil
+}

pkg/frontend/manager_windows.go

@@ -0,0 +1,20 @@
+//go:build windows
+
+package frontend
+
+import (
+	"os/exec"
+)
+
+// setupProcessGroup is a no-op on Windows
+func setupProcessGroup(cmd *exec.Cmd) {
+	// Windows doesn't use process groups the same way
+}
+
+// stopProcess stops the process on Windows
+func stopProcess(cmd *exec.Cmd) error {
+	if cmd == nil || cmd.Process == nil {
+		return nil
+	}
+	return cmd.Process.Kill()
+}