Use floats and not ints as otherwise 32bit php can not represent very difficult guesses effectively

Author: Xon

src/Matchers/BaseMatch.php

@@ -138,14 +138,14 @@ public static function binom(int $n, int $k): int
         return $res;
     }
 
-    abstract protected function getRawGuesses(): int;
+    abstract protected function getRawGuesses(): float;
 
-    public function getGuesses(): int
+    public function getGuesses(): float
     {
         return max($this->getRawGuesses(), $this->getMinimumGuesses());
     }
 
-    protected function getMinimumGuesses(): int
+    protected function getMinimumGuesses(): float
     {
         if (mb_strlen($this->token) < mb_strlen($this->password)) {
             if (mb_strlen($this->token) === 1) {

src/Matchers/Bruteforce.php

@@ -39,11 +39,11 @@ public function getFeedback(bool $isSoleMatch): array
         ];
     }
 
-    public function getRawGuesses(): int
+    public function getRawGuesses(): float
     {
         $guesses = pow(self::BRUTEFORCE_CARDINALITY, mb_strlen($this->token));
-        if ($guesses > PHP_INT_MAX) {
-            return PHP_INT_MAX;
+        if ($guesses === INF) {
+            return PHP_FLOAT_MAX;
         }
 
         // small detail: make bruteforce matches at minimum one guess bigger than smallest allowed
@@ -54,6 +54,6 @@ public function getRawGuesses(): int
             $minGuesses = Scorer::MIN_SUBMATCH_GUESSES_MULTI_CHAR + 1;
         }
 
-        return (int)max($guesses, $minGuesses);
+        return max($guesses, $minGuesses);
     }
 }

src/Matchers/DateMatch.php

@@ -408,7 +408,7 @@ protected static function removeRedundantMatches(array $matches): array
         });
     }
 
-    protected function getRawGuesses(): int
+    protected function getRawGuesses(): float
     {
         // base guesses: (year distance from REFERENCE_YEAR) * num_days * num_years
         $yearSpace = max(abs($this->year - static::getReferenceYear()), static::MIN_YEAR_SPACE);

src/Matchers/DictionaryMatch.php

@@ -191,15 +191,15 @@ protected static function getRankedDictionaries(): array
         return self::$rankedDictionaries;
     }
 
-    protected function getRawGuesses(): int
+    protected function getRawGuesses(): float
     {
         $guesses = $this->rank;
         $guesses *= $this->getUppercaseVariations();
 
         return $guesses;
     }
 
-    protected function getUppercaseVariations(): int
+    protected function getUppercaseVariations(): float
     {
         $word = $this->token;
         if (preg_match(self::ALL_LOWER, $word) || mb_strtolower($word) === $word) {

src/Matchers/L33tMatch.php

@@ -202,12 +202,12 @@ protected static function substitutionTableHelper(array $table, array $keys, arr
         return self::substitutionTableHelper($table, $otherKeys, $nextSubs);
     }
 
-    protected function getRawGuesses(): int
+    protected function getRawGuesses(): float
     {
         return parent::getRawGuesses() * $this->getL33tVariations();
     }
 
-    protected function getL33tVariations(): int
+    protected function getL33tVariations(): float
     {
         $variations = 1;
 

src/Matchers/MatchInterface.php

@@ -16,7 +16,7 @@ interface MatchInterface
      */
     public static function match(string $password, array $userInputs = []): array;
 
-    public function getGuesses(): int;
+    public function getGuesses(): float;
 
     public function getGuessesLog10(): float;
 }

src/Matchers/RepeatMatch.php

@@ -114,7 +114,7 @@ public function __construct(string $password, int $begin, int $end, string $toke
         }
     }
 
-    protected function getRawGuesses(): int
+    protected function getRawGuesses(): float
     {
         return $this->baseGuesses * $this->repeatCount;
     }

src/Matchers/ReverseDictionaryMatch.php

@@ -34,7 +34,7 @@ public static function match(string $password, array $userInputs = [], array $ra
         return $matches;
     }
 
-    protected function getRawGuesses(): int
+    protected function getRawGuesses(): float
     {
         return parent::getRawGuesses() * 2;
     }

src/Matchers/SequenceMatch.php

@@ -110,7 +110,7 @@ public function __construct(string $password, int $begin, int $end, string $toke
         }
     }
 
-    protected function getRawGuesses(): int
+    protected function getRawGuesses(): float
     {
         $firstCharacter = mb_substr($this->token, 0, 1);
         $guesses = 0;

src/Matchers/SpatialMatch.php

@@ -214,7 +214,7 @@ public static function getAdjacencyGraphs(): array
         return self::$adjacencyGraphs;
     }
 
-    protected function getRawGuesses(): int
+    protected function getRawGuesses(): float
     {
         if ($this->graph === 'qwerty' || $this->graph === 'dvorak') {
             $startingPosition = self::KEYBOARD_STARTING_POSITION;