This actually needs to use new static

mkopinsky · mkopinsky · commit 5928721397be · 2024-11-19T19:50:33.000-05:00
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -0,0 +1,7 @@
+parameters:
+	ignoreErrors:
+		-
+			message: '#^Unsafe usage of new static\(\)\.$#'
+			identifier: new.static
+			count: 1
+			path: src/Matchers/DictionaryMatch.php
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,3 +1,6 @@
+includes:
+	- phpstan-baseline.neon
+
 parameters:
 	level: 0
 	paths:
diff --git a/src/Matchers/DictionaryMatch.php b/src/Matchers/DictionaryMatch.php
@@ -62,7 +62,7 @@ public static function match(string $password, array $userInputs = [], array $ra
             $results = static::dictionaryMatch($password, $dict);
             foreach ($results as $result) {
                 $result['dictionary_name'] = $name;
-                $matches[] = new DictionaryMatch($password, $result['begin'], $result['end'], $result['token'], $result);
+                $matches[] = new static($password, $result['begin'], $result['end'], $result['token'], $result);
             }
         }
         Matcher::usortStable($matches, [Matcher::class, 'compareMatches']);

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public static function match(string $password, array $userInputs = [], array $ra`
`62`	`62`	`$results = static::dictionaryMatch($password, $dict);`
`63`	`63`	`foreach ($results as $result) {`
`64`	`64`	`$result['dictionary_name'] = $name;`
`65`		`- $matches[] = new DictionaryMatch($password, $result['begin'], $result['end'], $result['token'], $result);`
	`65`	`+ $matches[] = new static($password, $result['begin'], $result['end'], $result['token'], $result);`
`66`	`66`	`}`
`67`	`67`	`}`
`68`	`68`	`Matcher::usortStable($matches, [Matcher::class, 'compareMatches']);`