Merge branch 'php84' into php84-ci

mkopinsky · mkopinsky · commit dad00ba0926a · 2024-11-19T20:01:04.000-05:00
diff --git a/src/Matchers/ReverseDictionaryMatch.php b/src/Matchers/ReverseDictionaryMatch.php
@@ -55,7 +55,7 @@ public function getFeedback(bool $isSoleMatch): array
         return $feedback;
     }
 
-    public static function mbStrRev(string $string, string $encoding = null): string
+    public static function mbStrRev(string $string, ?string $encoding = null): string
     {
         if ($encoding === null) {
             $encoding = mb_detect_encoding($string) ?: 'UTF-8';

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function getFeedback(bool $isSoleMatch): array`
`55`	`55`	`return $feedback;`
`56`	`56`	`}`
`57`	`57`
`58`		`- public static function mbStrRev(string $string, string $encoding = null): string`
	`58`	`+ public static function mbStrRev(string $string, ?string $encoding = null): string`
`59`	`59`	`{`
`60`	`60`	`if ($encoding === null) {`
`61`	`61`	`$encoding = mb_detect_encoding($string) ?: 'UTF-8';`