Upgrade to phpunit 8.5 which supports php 7.2 through 8.0 (#49)

The library is still limited to PHP ^7.2 - this change is a prereq for full PHP8 compatibility which will come in the next PR.

Author: mkopinsky

.github/workflows/ci.yml

@@ -12,7 +12,6 @@ jobs:
           # - windows-latest # Disabled - apparently checkouts have \r\n which breaks phpcs
           - macos-latest
         php-versions:
-          - '7.1'
           - '7.2'
           - '7.3'
           - '7.4'

.gitignore

@@ -3,3 +3,4 @@ build/
 phpunit.xml
 .idea/
 composer.lock
+.phpunit.result.cache

composer.json

@@ -12,11 +12,11 @@
         }
     ],
     "require": {
-        "php": "^7.1",
+        "php": "^7.2",
         "symfony/polyfill-mbstring": ">=1.3.1"
     },
     "require-dev": {
-        "phpunit/phpunit": "^7.0",
+        "phpunit/phpunit": "^8.5",
         "php-coveralls/php-coveralls": "*",
         "squizlabs/php_codesniffer": "3.*"
     },

test/FeedbackTest.php

@@ -13,7 +13,7 @@ class FeedbackTest extends TestCase
     /** @var Feedback */
     private $feedback;
 
-    public function setUp()
+    public function setUp(): void
     {
         $this->feedback = new Feedback();
     }
@@ -48,9 +48,9 @@ public function testLongestMatchGetsFeedback()
     {
         $match1 = new SequenceMatch('abcd26-01-1991', 0, 4, 'abcd');
         $match2 = new DateMatch('abcd26-01-1991', 4, 14, '26-01-1991', [
-            'day' => 26,
-            'month' => 1,
-            'year' => 1991,
+            'day'       => 26,
+            'month'     => 1,
+            'year'      => 1991,
             'separator' => '-',
         ]);
         $feedback = $this->feedback->getFeedback(1, [$match1, $match2]);
@@ -75,9 +75,9 @@ public function testLongestMatchGetsFeedback()
     public function testDefaultSuggestion()
     {
         $match = new DateMatch('26-01-1991', 0, 10, '26-01-1991', [
-            'day' => 26,
-            'month' => 1,
-            'year' => 1991,
+            'day'       => 26,
+            'month'     => 1,
+            'year'      => 1991,
             'separator' => '-',
         ]);
         $feedback = $this->feedback->getFeedback(1, [$match]);

test/ScorerTest.php

@@ -16,10 +16,11 @@ class ScorerTest extends TestCase
     /** @var Scorer */
     private $scorer;
 
-    public function setUp()
+    public function setUp(): void
     {
         $this->scorer = new Scorer();
     }
+
     public function testBlankPassword()
     {
         $result = $this->scorer->getMostGuessableMatchSequence('', []);

test/TimeEstimatorTest.php

@@ -10,7 +10,7 @@ class TimeEstimatorTest extends TestCase
     /** @var TimeEstimator */
     private $timeEstimator;
 
-    public function setUp()
+    public function setUp(): void
     {
         $this->timeEstimator = new TimeEstimator();
     }

test/ZxcvbnTest.php

@@ -13,7 +13,7 @@ class ZxcvbnTest extends TestCase
     /** @var Zxcvbn */
     private $zxcvbn;
 
-    public function setUp()
+    public function setUp(): void
     {
         $this->zxcvbn = new Zxcvbn();
     }
@@ -39,7 +39,7 @@ public function typeDataProvider()
             ['crack_times_seconds', 'array'],
             ['crack_times_display', 'array'],
             ['feedback', 'array'],
-            ['calc_time', 'numeric']
+            ['calc_time', 'numeric'],
         ];
     }
 
@@ -87,11 +87,11 @@ public function sanityCheckDataProvider()
      * Some basic sanity checks. All of the underlying functionality is tested in more details in their specific
      * classes, but this is just to check that it's all tied together correctly at the end.
      * @dataProvider sanityCheckDataProvider
-     * @param string   $password
-     * @param int      $score
+     * @param string $password
+     * @param int $score
      * @param string[] $patterns
-     * @param string   $slowHashingDisplay
-     * @param float    $guesses
+     * @param string $slowHashingDisplay
+     * @param float $guesses
      */
     public function testZxcvbnSanityCheck($password, $score, $patterns, $slowHashingDisplay, $guesses)
     {