Add tests

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Author: bjosv

tests/CMakeLists.txt

@@ -97,6 +97,10 @@ target_include_directories(ut_slotmap_update PRIVATE "${PROJECT_SOURCE_DIR}/src"
 target_link_libraries(ut_slotmap_update valkey_unittest)
 add_test(NAME ut_slotmap_update COMMAND "$<TARGET_FILE:ut_slotmap_update>")
 
+add_executable(ut_slot_by_key ut_slot_by_key.c)
+target_link_libraries(ut_slot_by_key valkey_unittest)
+add_test(NAME ut_slot_by_key COMMAND "$<TARGET_FILE:ut_slot_by_key>")
+
 # Cluster tests
 add_executable(ct_commands ct_commands.c test_utils.c)
 target_link_libraries(ct_commands valkey ${TLS_LIBRARY})

tests/ct_specific_nodes.c

@@ -498,6 +498,22 @@ void test_async_transaction(void) {
     event_base_free(base);
 }
 
+void test_get_node_by_key(valkeyClusterContext *cc) {
+    /* A key with embedded null should use the full length for slot
+     * calculation, not stop at the null byte. */
+    valkeyClusterNode *node_full = valkeyClusterGetNodeByKey(cc, (char *)"ke\0y", 4);
+    valkeyClusterNode *node_truncated = valkeyClusterGetNodeByKey(cc, (char *)"ke", 2);
+    assert(node_full != NULL);
+    assert(node_truncated != NULL);
+    assert(node_full != node_truncated);
+}
+
+void test_get_node_by_key_empty(valkeyClusterContext *cc) {
+    /* An empty string is a valid key. */
+    valkeyClusterNode *node = valkeyClusterGetNodeByKey(cc, (char *)"", 0);
+    assert(node != NULL);
+}
+
 int main(void) {
     valkeyClusterOptions options = {0};
     options.initial_nodes = CLUSTER_NODE;
@@ -512,6 +528,8 @@ int main(void) {
     test_command_to_all_nodes(cc);
     test_transaction(cc);
     test_streams(cc);
+    test_get_node_by_key(cc);
+    test_get_node_by_key_empty(cc);
 
     // Pipeline API
     test_pipeline_to_single_node(cc);

tests/ut_slot_by_key.c

@@ -0,0 +1,41 @@
+/* Unit tests for valkeyClusterGetSlotByKey. */
+
+#include "cluster.h"
+#include "test_utils.h"
+
+#include <assert.h>
+
+void test_slot_by_key_basic(void) {
+    /* A simple key should produce a consistent slot. */
+    unsigned int slot = valkeyClusterGetSlotByKey((char *)"foo", 3);
+    assert(slot == valkeyClusterGetSlotByKey((char *)"foo", 3));
+}
+
+void test_slot_by_key_with_hashtag(void) {
+    /* Keys with the same hash tag should map to the same slot. */
+    unsigned int slot1 = valkeyClusterGetSlotByKey((char *)"{tag}key1", 9);
+    unsigned int slot2 = valkeyClusterGetSlotByKey((char *)"{tag}key2", 9);
+    assert(slot1 == slot2);
+}
+
+void test_slot_by_key_binary_safe(void) {
+    /* Key with embedded null: "ke\0y" (length 4) should produce a
+     * different slot than "ke" (length 2, what strlen would give). */
+    unsigned int slot_full = valkeyClusterGetSlotByKey((char *)"ke\0y", 4);
+    unsigned int slot_truncated = valkeyClusterGetSlotByKey((char *)"ke", 2);
+    assert(slot_full != slot_truncated);
+}
+
+void test_slot_by_key_empty(void) {
+    /* An empty string is a valid key. */
+    unsigned int slot = valkeyClusterGetSlotByKey((char *)"", 0);
+    assert(slot == 0);
+}
+
+int main(void) {
+    test_slot_by_key_basic();
+    test_slot_by_key_with_hashtag();
+    test_slot_by_key_binary_safe();
+    test_slot_by_key_empty();
+    return 0;
+}