Add CI job to build on Solaris

Add fmacros.h to enable strncasecmp in command.h

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>

Author: bjosv

.github/workflows/build.yml

@@ -74,6 +74,18 @@ jobs:
             gmake
             mkdir build && cd build && cmake .. && gmake
 
+  solaris:
+    runs-on: ubuntu-latest
+    name:  Solaris
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - name: Build in Solaris
+        uses: vmactions/solaris-vm@58cbd70c6e051860f9b8f65908cc582938fbbdba # v1.1.5
+        with:
+          prepare: pkgutil -y -i gmake gcc5core openssl_utils
+          run: |
+            USE_TLS=1 gmake
+
   build-cross:
     name: Cross-compile ${{ matrix.config.target }}
     runs-on: ubuntu-22.04

Makefile

@@ -184,7 +184,7 @@ endif
 
 ifeq ($(uname_S),FreeBSD)
   LDFLAGS += -lm
-else ifeq ($(UNAME_S),SunOS)
+else ifeq ($(uname_S),SunOS)
   ifeq ($(shell $(CC) -V 2>&1 | grep -iq 'sun\|studio' && echo true),true)
     SUN_SHARED_FLAG = -G
   else

src/command.c

@@ -28,6 +28,8 @@
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  */
+#include "fmacros.h"
+
 #include <assert.h>
 #include <ctype.h>
 #include <errno.h>

src/fmacros.h

@@ -2,7 +2,14 @@
 #define VALKEY_FMACRO_H
 
 #ifndef _AIX
+// Default: freebsd alloca missing
+
+// Needed for FreeBSD cluster.c gettimeofday() random()
+// Needed for strdup in all linux builds
+#ifndef __FreeBSD__
 #define _XOPEN_SOURCE 600
+#endif
+
 #define _POSIX_C_SOURCE 200112L
 #endif