regression: DateTimeInterface not avail in PHP 5.4 / prefer === false vs "!"

Author: bkdotcom

.github/workflows/phpunit.yml

@@ -55,7 +55,9 @@ jobs:
         restore-keys: |
           ${{ runner.os }}-php-
     - name: Install dependencies
-      run: composer install --prefer-dist --no-progress
+      run: |
+        composer --version
+        composer install --prefer-dist --no-progress
     - name: Unit test
       run: composer run test
     - name: Publish code coverage

src/Backtrace/SkipInternal.php

@@ -52,7 +52,7 @@ public static function addInternalClass($classes, $level = 0)
         if (\is_int($level) === false) {
             throw new InvalidArgumentException(\sprintf('level must be an integer'));
         }
-        if (!\is_array($classes)) {
+        if (\is_array($classes) === false) {
             $classes = array($classes => $level);
         }
         foreach ($classes as $key => $val) {

src/Debug/Abstraction/AbstractObject.php

@@ -233,7 +233,9 @@ public static function buildObjValues($values = array())
     public function onStart(Abstraction $abs)
     {
         $obj = $abs->getSubject();
-        if ($obj instanceof \DateTimeInterface) {
+        if ($obj instanceof \DateTime || $obj instanceof \DateTimeImmutable) {
+            // check for both DateTime and DateTimeImmutable
+            //   DateTimeInterface (and DateTimeImmutable) not available until Php 5.5
             $abs['isTraverseOnly'] = false;
             $abs['stringified'] = $obj->format(\DateTime::ISO8601);
         } elseif ($obj instanceof \mysqli) {

src/Debug/Abstraction/AbstractObjectMethodParams.php

@@ -285,7 +285,7 @@ private function phpDocConstant($defaultValue, $className, $matches)
      */
     private function phpDocParamValue($param, $className = null)
     {
-        if (!\array_key_exists('defaultValue', $param)) {
+        if (\array_key_exists('defaultValue', $param) === false) {
             return Abstracter::UNDEFINED;
         }
         $defaultValue = $param['defaultValue'];

src/Debug/Abstraction/AbstractString.php

@@ -247,7 +247,7 @@ private function getMaxLen($cat, $strlen)
         $maxlen = \array_key_exists($cat, $stringMaxLen)
             ? $stringMaxLen[$cat]
             : $stringMaxLen['other'];
-        if (!\is_array($maxlen)) {
+        if (\is_array($maxlen) === false) {
             return $maxlen !== null
                 ? $maxlen
                 : -1;

src/Debug/Abstraction/Abstracter.php

@@ -465,7 +465,7 @@ protected function postSetCfg($cfg = array(), $prev = array())
             $cfg['objectsExclude'] = $this->cfg['objectsExclude'];
         }
         if (isset($cfg['stringMaxLen'])) {
-            if (!\is_array($cfg['stringMaxLen'])) {
+            if (\is_array($cfg['stringMaxLen']) === false) {
                 $cfg['stringMaxLen'] = array(
                     'other' => $cfg['stringMaxLen'],
                 );

src/Debug/Debug.php

@@ -845,7 +845,7 @@ public static function meta()
             $args[0]['debug'] = self::META;
             return $args[0];
         }
-        if (!\is_string($args[0])) {
+        if (\is_string($args[0]) === false) {
             // invalid / return empty meta array
             return array('debug' => self::META);
         }

src/Debug/Dump/Html/HtmlObject.php

@@ -257,7 +257,7 @@ protected function dumpPhpDoc(Abstraction $abs)
     {
         $str = '<dt>phpDoc</dt>' . "\n";
         foreach ($abs['phpDoc'] as $tagName => $values) {
-            if (!\is_array($values)) {
+            if (\is_array($values) === false) {
                 continue;
             }
             foreach ($values as $tagData) {

src/Debug/Dump/Substitution.php

@@ -54,7 +54,7 @@ public function __construct(Dumper $dumper)
      */
     public function process($args, $options = array())
     {
-        if (!\is_string($args[0])) {
+        if (\is_string($args[0]) === false) {
             return $args;
         }
         $this->subInfo = array(
@@ -97,7 +97,7 @@ private function processSubsCallback($matches)
     {
         $index = ++$this->subInfo['index'];
         $replace = $matches[0];
-        if (!\array_key_exists($index, $this->subInfo['args'])) {
+        if (\array_key_exists($index, $this->subInfo['args']) === false) {
             return $replace;
         }
         $arg = $this->subInfo['args'][$index];

src/Debug/Framework/Yii2/Module.php

@@ -259,7 +259,7 @@ protected function collectEvent()
             $this->module->getVersion() returns the application "module" version vs framework version ¯\_(ツ)_/¯
         */
         $yiiVersion = Yii::getVersion();  // Framework version
-        if (!\version_compare($yiiVersion, '2.0.14', '>=')) {
+        if (\version_compare($yiiVersion, '2.0.14', '<')) {
             return;
         }
         YiiEvent::on('*', '*', function (YiiEvent $event) {