minor clean up of handing ellipsis

Author: apple1417

options.py

@@ -104,12 +104,6 @@ def __init__(self) -> None:
         raise NotImplementedError
 
     def _to_json(self) -> J:
-        """
-        Turns this option into a JSON value.
-
-        Returns:
-            This option's JSON representation.
-        """
         return self.value
 
     def __post_init__(self) -> None:
@@ -364,12 +358,6 @@ class ButtonOption(BaseOption):
     on_press: Callable[[Self], None] | None = None
 
     def _to_json(self) -> EllipsisType:
-        """
-        A dummy method to adhere to BaseOption interface, while indicating no JSON representation.
-
-        Returns:
-            Ellipsis, indicating that ButtonOption cannot be represented as a value.
-        """
         return ...
 
     def _from_json(self, value: JSON) -> None:
@@ -479,12 +467,11 @@ class GroupedOption(BaseOption):
     children: Sequence[BaseOption]
 
     def _to_json(self) -> JSON:
-        grouped_option_dict: Mapping[str, JSON] = {}
-        for option in self.children:
-            if option._to_json() == ...:
-                continue
-            grouped_option_dict[option.identifier] = cast(JSON, option._to_json())
-        return grouped_option_dict
+        return {
+            option.identifier: child_json
+            for option in self.children
+            if (child_json := option._to_json()) is not ...
+        }
 
     def _from_json(self, value: JSON) -> None:
         if isinstance(value, Mapping):
@@ -523,12 +510,11 @@ class NestedOption(BaseOption):
     children: Sequence[BaseOption]
 
     def _to_json(self) -> JSON:
-        grouped_option_dict: Mapping[str, JSON] = {}
-        for option in self.children:
-            if option._to_json() == ...:
-                continue
-            grouped_option_dict[option.identifier] = cast(JSON, option._to_json())
-        return grouped_option_dict
+        return {
+            option.identifier: child_json
+            for option in self.children
+            if (child_json := option._to_json()) is not ...
+        }
 
     def _from_json(self, value: JSON) -> None:
         if isinstance(value, Mapping):

settings.py

@@ -2,7 +2,7 @@
 
 import json
 from collections.abc import Mapping, Sequence
-from typing import TYPE_CHECKING, TypedDict, cast
+from typing import TYPE_CHECKING, TypedDict
 
 from . import MODS_DIR
 
@@ -81,14 +81,12 @@ def create_options_dict(options: Sequence[BaseOption]) -> dict[str, JSON]:
     Returns:
         The options' values in dict form.
     """
-    settings: dict[str, JSON] = {
-        option.identifier: cast(JSON, option._to_json())  # type: ignore
+    return {
+        option.identifier: child_json
         for option in options
-        if option._to_json() != ...  # type: ignore
+        if (child_json := option._to_json()) is not ...  # pyright: ignore[reportPrivateUsage]
     }
 
-    return settings
-
 
 def default_save_mod_settings(self: Mod) -> None:
     """Default implementation for Mod.save_settings."""