Merge pull request #8 from apple1417/master

fix update available notification not immediately clearing after updating

Author: apple1417

Readme.md

@@ -19,7 +19,10 @@ game specific things:
 
 # Changelog
 
-### v1.7 (Upcoming)
+### v1.7
+- The "Update Available" notification should now immediately go away upon updating, instead of
+  waiting a day for the next check.
+
 - Changed the functions the keybind implementation should overwrite from `KeybindType.enable` to
   `KeybindType._enable` (+ same for disable). These functions don't need to set `is_enabled`.
 

mod_list.py

@@ -228,9 +228,9 @@ def get_this_release_tuple(self) -> tuple[int, ...] | None:
             return None
         return tuple(int(x) for x in version_match.groups())
 
-    def get_latest_release_version(self) -> tuple[str, tuple[int, ...]] | tuple[None, None]:
+    def fetch_latest_version(self) -> tuple[str, tuple[int, ...]] | tuple[None, None]:
         """
-        Gets the version of the latest release.
+        Fetches the version of the latest release from github.
 
         Should be called in a thread, as this makes a blocking HTTP request.
 
@@ -260,6 +260,29 @@ def get_latest_release_version(self) -> tuple[str, tuple[int, ...]] | tuple[None
             unrealsdk.logging.dev_warning(traceback.format_exc())
             return None, None
 
+    def get_latest_cached_version(self) -> tuple[str, tuple[int, ...]] | tuple[None, None]:
+        """
+        Gets the version of the latest release from our cached setting.
+
+        Returns:
+            A tuple of the latest version name and version tuple, or None and None if unknown.
+        """
+        try:
+            name = self.latest_version_option.value
+            if name is None:
+                raise ValueError
+
+            match = RE_MANAGER_VERSION.match(name)
+            if match is None:
+                raise ValueError
+
+            return name, tuple(int(x) for x in match.groups())
+
+        except Exception:  # noqa: BLE001
+            self.latest_version_option.value = None
+            self.save_settings()
+            return None, None
+
     def perform_version_check(self) -> None:
         """
         Checks if there's a newer version, and updates the options appropriately.
@@ -271,16 +294,20 @@ def perform_version_check(self) -> None:
             unrealsdk.logging.warning("Skipping SDK update check since current version is unknown")
             return
 
+        fetch_new_version = False
         try:
             next_check_time = datetime.fromisoformat(self.next_version_check_time_option.value)
-            if next_check_time > datetime.now(UTC):
-                # Not time yet
-                return
+            if next_check_time < datetime.now(UTC):
+                fetch_new_version = True
         except ValueError:
-            # If we failed to parse the option, assume we need a new check
-            pass
+            # If we failed to parse the option, assume we need to re-fetch
+            fetch_new_version = True
+
+        if fetch_new_version:
+            latest_version_name, latest_version_tuple = self.fetch_latest_version()
+        else:
+            latest_version_name, latest_version_tuple = self.get_latest_cached_version()
 
-        latest_version_name, latest_version_tuple = self.get_latest_release_version()
         if latest_version_name is None or latest_version_tuple is None:
             return