Skip to content

Commit b4c8745

Browse files
committed
linux ci improvements
two things: - we weren't logging in to ghcr, so were never using cached images - some errors weren't getting caught
1 parent f4276ed commit b4c8745

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

.github/workflows/build.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,13 @@ jobs:
101101
with:
102102
submodules: recursive
103103

104+
- name: Login to GitHub Container Registry
105+
uses: docker/login-action@v2
106+
with:
107+
registry: ghcr.io
108+
username: ${{ github.repository_owner }}
109+
password: ${{ secrets.GITHUB_TOKEN }}
110+
104111
- name: Build
105112
uses: devcontainers/[email protected]
106113
with:
@@ -115,12 +122,14 @@ jobs:
115122
git config --global --add safe.directory `pwd`/libs/pyunrealsdk
116123
git config --global --add safe.directory `pwd`/libs/pyunrealsdk/libs/unrealsdk
117124
125+
set -e
126+
118127
cmake . --preset ${{ matrix.toolchain.preset }} -G Ninja
119128
cmake --build out/build/${{ matrix.toolchain.preset }} --target install
120129
121-
[ ${{ inputs.new-release-tag == '' && 1 || 0 }} -ne 0 ] \
122-
&& python prepare_release.py ${{ matrix.toolchain.preset }} --skip-install --no-bl3 --no-wl --unified \
123-
|| true
130+
if [ ${{ inputs.new-release-tag == '' && 1 || 0 }} -ne 0 ]; then
131+
python prepare_release.py ${{ matrix.toolchain.preset }} --skip-install --no-bl3 --no-wl --unified
132+
fi
124133
125134
- name: Upload Artifact
126135
if: inputs.new-release-tag == ''

0 commit comments

Comments
 (0)