try containerize linux builds

cherry pick of 1528ee2

Author: apple1417

.github/workflows/build.yml

@@ -58,76 +58,38 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        preset: [
-          "clang-cross-ue3-x86-release",
-          "clang-cross-ue4-x64-release",
-          "llvm-mingw-ue3-x86-release",
-          "llvm-mingw-ue4-x64-release",
-          "mingw-ue3-x86-release",
-          "mingw-ue4-x64-release",
-        ]
+        toolchain:
+          - preset: clang-cross-ue3-x86-release
+            container: clang-cross
+          - preset: clang-cross-ue4-x64-release
+            container: clang-cross
+          - preset: llvm-mingw-ue3-x86-release
+            container: llvm-mingw
+          - preset: llvm-mingw-ue4-x64-release
+            container: llvm-mingw
+          - preset: mingw-ue3-x86-release
+            container: mingw
+          - preset: mingw-ue4-x64-release
+            container: mingw
 
     steps:
-    - name: Setup CMake and Ninja
-      uses: lukka/get-cmake@latest
-
-    - name: Setup LLVM MinGW
-      if: startswith(matrix.preset, 'llvm-mingw')
-      run: |
-        wget -nv ${{ env.LLVM_MINGW_DOWNLOAD }}
-        tar -xf ${{ env.LLVM_MINGW_VERSION }}.tar.xz -C ~/
-        echo $(readlink -f ~/${{ env.LLVM_MINGW_VERSION }}/bin) >> $GITHUB_PATH
-
-    - name: Setup MinGW
-      if: startswith(matrix.preset, 'mingw')
-      uses: egor-tensin/setup-mingw@v2
-      with:
-        platform: ${{ fromJSON('["x86", "x64"]')[contains(matrix.preset, 'x64')] }}
-
-    - name: Setup Clang
-      if: startswith(matrix.preset, 'clang-cross')
-      uses: egor-tensin/setup-clang@v1
-
-    - name: Restore win sdk cache
-      if: startswith(matrix.preset, 'clang-cross')
-      uses: actions/cache@v4
-      id: cache-win-sdk
-      with:
-        path: ~/win-sdk
-        key: ${{ runner.os }}-win-sdk
-
-    - name: Setup msitools
-      if: startswith(matrix.preset, 'clang-cross') && steps.cache-win-sdk.outputs.cache-hit != 'true'
-      uses: awalsh128/cache-apt-pkgs-action@latest
-      with:
-        packages: msitools
-        version: ${{ runner.os }}-msitools
-
-    - name: Setup win sdk
-      if: startswith(matrix.preset, 'clang-cross') && steps.cache-win-sdk.outputs.cache-hit != 'true'
-      run: |
-        git clone https://github.com/mstorsjo/msvc-wine.git
-        msvc-wine/vsdownload.py --accept-license --dest ~/win-sdk Microsoft.VisualStudio.Workload.VCTools
-        msvc-wine/install.sh ~/win-sdk
-        rm -r msvc-wine
-
-    - name: Checkout repository and submodules
-      uses: actions/checkout@v4
-      with:
-        submodules: recursive
-
-    - name: Configure CMake
-      working-directory: ${{ env.GITHUB_WORKSPACE }}
-      # The extra msvc wine arg won't do anything if we're not cross compiling
-      run: >
-        cmake .
-        --preset ${{ matrix.preset }}
-        -G Ninja
-        -DMSVC_WINE_ENV_SCRIPT=$(readlink -f ~)/win-sdk/bin/${{ fromJSON('["x86", "x64"]')[contains(matrix.preset, 'x64')] }}/msvcenv.sh
+      - name: Checkout repository and submodules
+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Build
+        uses: devcontainers/[email protected]
+        with:
+          cacheFrom: ghcr.io/bl-sdk/${{ matrix.toolchain.container }}:latest
+          configFile: .devcontainer/${{ matrix.toolchain.container }}/devcontainer.json
+          push: never
+          # The git watcher cmake thinks something's unsafe? Doesn't happen to me locally.
+          runCmd: |
+            git config --global --add safe.directory `pwd`
+            cmake . --preset ${{ matrix.toolchain.preset }} -G Ninja
+            cmake --build out/build/${{ matrix.toolchain.preset }}
 
-    - name: Build
-      working-directory: ${{ env.GITHUB_WORKSPACE }}
-      run: cmake --build out/build/${{ matrix.preset }}
 
 # ==============================================================================
 

CMakePresets.json

@@ -40,6 +40,9 @@
         "lhs": "${hostSystemName}",
         "rhs": "Windows"
       },
+      "environment": {
+        "MSVC_WINE_ENV_SCRIPT": "/win-sdk/bin/x86/msvcenv.sh"
+      },
       "toolchainFile": "common_cmake/clang-cross-x86.cmake"
     },
     {
@@ -50,6 +53,9 @@
         "lhs": "${hostSystemName}",
         "rhs": "Windows"
       },
+      "environment": {
+        "MSVC_WINE_ENV_SCRIPT": "/win-sdk/bin/x64/msvcenv.sh"
+      },
       "toolchainFile": "common_cmake/clang-cross-x64.cmake"
     },
     {

README.md

@@ -142,13 +142,24 @@ This turns out to be a bit of a problem - MSVC and GNU have different exception
 both. Practically, this means when cross compiling, you should either compile everything from
 scratch, or setup Clang to build with the MSVC ABI. [See this blog post for more info](https://apple1417.dev/posts/2023-05-18-debugging-proton).
 
-# Running the SDK by itself
+# Building the SDK by itself
 The shared library is also useful when developing for the sdk itself, since it's the minimal
-configuration to get it running. The CMake presets are set up to build this.
-
-Note that you will need to use some game specific plugin loader to get the dll loaded. It is not set
-up to alias any system dlls (since when actually using it as a library you don't want that), you
-can't just call it `d3d9.dll` and assume your game will load fine.
+configuration to get it running. The CMake presets are set up to build this. There are currently
+five supported toolchains, each of which have a few different sdk configurations:
+
+- MSVC
+- Clang (Windows)
+- Clang (Cross Compile) <sup>*</sup>
+- MinGW <sup>*</sup>
+- LLVM MinGW <sup>*</sup>
+
+The toolchains with an asterix are all cross compiling toolchains. These all also have an associated
+dev container, which is the recommended way of building them. The `clang-cross-*` presets in
+particular hardcode a path assuming they're running in the container.
+
+Note that you will need to use some game specific plugin loader to get the `unrealsdk.dll` loaded.
+It is not set up to alias any system dlls (since when actually using it as a library you don't want
+that), you can't just rename it to `d3d9.dll` and assume your game will load fine.
 
 To build:
 

src/unrealsdk/unreal/structs/fname.h

@@ -84,7 +84,9 @@ struct hash<unrealsdk::unreal::FName> {
     size_t operator()(const unrealsdk::unreal::FName& name) const {
         static_assert(sizeof(unrealsdk::unreal::FName) == sizeof(uint64_t),
                       "FName is not same size as a uint64");
-        return hash<uint64_t>()(*reinterpret_cast<const uint64_t*>(&name));
+        uint64_t val{};
+        memcpy(&val, &name, sizeof(name));
+        return hash<uint64_t>()(val);
     }
 };