Merge pull request #39 from apple1417/master

add fixup for loot randomizer using bad type

Author: apple1417

changelog.md

@@ -3,7 +3,7 @@
 ## v3.5 (Upcoming)
 
 ### Legacy Compat v1.4
-- Added more fixups for previously unreported issues in Reign of Giants.
+- Added more fixups for previously unreported issues in Loot Randomizer and Reign of Giants.
 
 ### Willow2 Mod Menu v3.4
 - Fixed that some keybinds would not be displayed properly if there were two separate grouped/nested

src/legacy_compat/meta_path_finder.py

@@ -188,5 +188,30 @@ def find_spec(  # noqa: D102
                     ),
                 )
 
+            # Loot randomizer needs a few fixes
+            case (
+                # Here's the downside of using a single folder name, these cases just look weird.
+                ("Mod", "Mods.LootRandomizer.Mod.missions")
+                # Newer versions split the files
+                | ("Mod", "Mods.LootRandomizer.Mod.bl2.locations")
+            ):
+                return spec_with_replacements(
+                    fullname,
+                    path,
+                    target,
+                    # It called these functions with a bad arg type in two places. This is
+                    # essentially undefined behaviour, so now gives an exception. Luckily, in this
+                    # case the functions actually validated their arg, so this just became a no-op.
+                    # Remove the two bad calls.
+                    (rb"get_missiontracker\(\)\.(Unr|R)egisterMissionDirector\(giver\)", b"pass"),
+                    # There's some code to hide Face McShooty's body on re-accepting the quest. I
+                    # think this broke due to the removal of CallPostEdit. Swapping it to use the
+                    # setter functions makes it work again.
+                    (
+                        rb"pawn.bHidden = True([\r\n]+ +)pawn.CollisionType = 1",
+                        rb"pawn.SetHidden(True)\1pawn.SetCollisionType(1)",
+                    ),
+                )
+
             case _, _:
                 return None