Feat/adam w (#237)

* feat[optimiser]: add more optimiser errors

* feat[optimisers]: add adamW

* fix[optimiser]: tests

* fix[optimisers]: fix more tests

* optimiser[adamw]: tests pass

* chore: clippy

---------

Co-authored-by: Marcus Cvjeticanin <[email protected]>

Author: distributedstatemachine

delta/src/classical_ml/losses.rs

@@ -108,7 +108,7 @@ where
             .zip(actuals.iter())
             .map(|(p, y)| {
                 let p_clamped = p.max(epsilon).min(T::one() - epsilon);
-                -(y.clone() * p_clamped.ln() + (T::one() - y.clone()) * (T::one() - p_clamped).ln())
+                -(*y * p_clamped.ln() + (T::one() - *y) * (T::one() - p_clamped).ln())
             })
             .sum::<T>()
             / m

delta/src/deep_learning/dataset/vision/cifar10.rs

@@ -95,7 +95,7 @@ impl Cifar10Dataset {
             let path = entry.path().unwrap().into_owned();
             let file_name = path.file_name().unwrap().to_string_lossy().to_string();
 
-            if path.is_dir() || !path.extension().map_or(false, |ext| ext == "bin") {
+            if path.is_dir() || path.extension().is_none_or(|ext| ext != "bin") {
                 continue;
             }
 

delta/src/deep_learning/dataset/vision/cifar100.rs

@@ -89,7 +89,7 @@ impl Cifar100Dataset {
             let path = entry.path().unwrap().into_owned();
             let file_name = path.file_name().unwrap().to_string_lossy().to_string();
 
-            if path.is_dir() || !path.extension().map_or(false, |ext| ext == "bin") {
+            if path.is_dir() || path.extension().is_none_or(|ext| ext != "bin") {
                 continue;
             }
 

delta/src/deep_learning/errors.rs

@@ -52,6 +52,16 @@ pub enum OptimizerError {
     IncompatibleGradientWeightShape(Vec<usize>, Vec<usize>),
     /// Error when epsilon is not set or is invalid.
     InvalidEpsilon(String),
+    /// Error when beta parameter is invalid.
+    InvalidBeta(String),
+    /// Error when weight decay parameter is invalid.
+    InvalidWeightDecay(String),
+    /// Error when gradient contains invalid values (NaN or Inf).
+    InvalidGradient(String),
+    /// Error when weight contains invalid values (NaN or Inf).
+    InvalidWeight(String),
+    /// Error when shapes don't match
+    ShapeMismatch(String),
 }
 
 /// An enumeration of possible errors that can occur in a model.
@@ -105,6 +115,11 @@ impl fmt::Display for OptimizerError {
                 write!(f, "Gradient shape {:?} is incompatible with weight shape {:?}", g, w)
             }
             OptimizerError::InvalidEpsilon(s) => write!(f, "{}", s),
+            OptimizerError::InvalidBeta(s) => write!(f, "{}", s),
+            OptimizerError::InvalidWeightDecay(s) => write!(f, "{}", s),
+            OptimizerError::InvalidGradient(s) => write!(f, "{}", s),
+            OptimizerError::InvalidWeight(s) => write!(f, "{}", s),
+            OptimizerError::ShapeMismatch(s) => write!(f, "Shape mismatch: {}", s),
         }
     }
 }