Repository navigation
Commit 6bcc3bb
jcode
test(preflight): make an exclusion's reason a required field, not a comment
A comment beside an entry can drift out of sync with it and nothing
notices, so a reader months later cannot tell a stale justification from
a live one. Moving the reason into the data the gate reads makes an
unexplained widening unparseable rather than merely undocumented.
Entries are now "path|reason". A missing or empty reason fails the check
before it runs, because running while blind to a file for reasons nobody
recorded is the same silent-success shape this whole line of work has
been about.
The two guards are independent on purpose and were verified separately,
since the count check fires first and would otherwise mask the field
check: removing a reason without changing the count fails with "exclusion
'.rename-outloud.py' has no reason", and adding an entry fails with "3
entries, expected 2".
Re-ran the original defect afterwards. It still fails, so the hardening
did not neuter what it hardens.1 parent 95a1192 commit 6bcc3bb
1 file changed
Lines changed: 20 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
259 | 264 | | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
| 265 | + | |
| 266 | + | |
264 | 267 | | |
265 | 268 | | |
266 | 269 | | |
| |||
277 | 280 | | |
278 | 281 | | |
279 | 282 | | |
280 | | - | |
281 | | - | |
282 | | - | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
283 | 296 | | |
284 | 297 | | |
285 | 298 | | |
| |||
0 commit comments