Repository navigation
Commit 82e165e
committed
Fix the duplicate focus_moved_to that broke every non-macOS target
CI has been red since 14:05 and I never looked, because a billing failure
made every job die in 2-3 seconds and I read that as infrastructure noise.
Making the repo public let the jobs actually run, and they immediately found
a real break.
`focus_moved_to` had two definitions: one unconditional, one gated
`cfg(not(target_os = "macos"))`. On macOS only the first compiled, so
everything looked fine locally. On every other target both existed and the
build failed with E0428.
Nine of the fifteen failing jobs were this one error: all four Linux targets,
both Windows targets, the Linux check job, MSRV, and repro.
Fixed by keeping the single definition whose BODY is cfg'd, which is the
shape the rest of this file already uses. My first attempt gated the
definition instead, and scripts/ci-check-cfg.sh correctly rejected it: the
call site in pipeline.rs is ungated, so that only moved the breakage.
That script caught this locally in seconds. I had run it earlier and it
passed, so the regression arrived with the frontmost_app fallback edit and
went unnoticed because I stopped re-running it after every change.1 parent 9f93217 commit 82e165e
1 file changed
Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1003 | 1003 | | |
1004 | 1004 | | |
1005 | 1005 | | |
1006 | | - | |
1007 | | - | |
1008 | | - | |
1009 | | - | |
1010 | | - | |
1011 | | - | |
1012 | | - | |
1013 | 1006 | | |
1014 | 1007 | | |
1015 | 1008 | | |
| |||
0 commit comments