add tests

Author: nshankar

check_pygrib_vs_herbie_crs_extraction.ipynb

@@ -15,7 +15,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 1,
+   "execution_count": 2,
    "metadata": {},
    "outputs": [],
    "source": [
@@ -129,15 +129,16 @@
     "    elif model[\"model\"] in (\"hrdps\",): # no historical data\n",
     "        date = pd.Timestamp(\"now\").floor(\"6h\") - pd.Timedelta(\"6h\")\n",
     "    else:\n",
-    "        date = \"2025-01-01\"\n",
+    "        date = \"2025-07-05T06:00:00\"\n",
     "\n",
-    "    ds = Herbie(date, verbose=False, **model).xarray(\n",
-    "        search, remove_grib=False, _use_pygrib_for_crs=False\n",
-    "    )\n",
+    "    # ds = Herbie(date, verbose=False, **model).xarray(\n",
+    "    #    search, remove_grib=False, _use_pygrib_for_crs=False\n",
+    "    # )\n",
+    "    ds = Herbie(date, verbose=False, **model).download()\n",
     "\n",
     "    print()\n",
     "    print(f\"Model: {model['model'].upper()}\")\n",
-    "    with pygrib.open(str(ds.local_grib)) as grb:\n",
+    "    with pygrib.open(str(ds)) as grb:\n",
     "        msg = grb.message(1)\n",
     "        projparams_dict_pygrib = dict(sorted(msg.projparams.items()))\n",
     "        print(\"  pygrib\", projparams_dict_pygrib)\n",

pyproject.toml

@@ -32,11 +32,12 @@ keywords = [
 dependencies = [
     "cfgrib>=0.9.15",
     "eccodes>=2.37.0",
+    "jupyter>=1.1.1",
     "numpy>=1.24",
     "pandas>=2.1",
     "pyproj>=3.7.0",
     "requests>=2.23.3",
-    "toml>=0.10.2", # TODO: Drop in favor of tomllib when Python >=3.11 is required.
+    "toml>=0.10.2",     # TODO: Drop in favor of tomllib when Python >=3.11 is required.
     "xarray>=2025.1.1",
 ]
 dynamic = ["version"]
@@ -56,6 +57,7 @@ build-backend = "hatchling.build"
 dev = [
     "ipykernel>=6.29.5",
     "jupyter>=1.1.1",
+    "netcdf4>=1.7.2",
     "pygrib>=2.1.6",
     "pytest>=8.3.5",
     "pytest-cov>=6.1.1",

tests/test_hrdps.py

@@ -0,0 +1,69 @@
+## Nikhil Shankar
+## August 10, 2025
+
+"""Tests for downloading HRDPS model."""
+
+from datetime import datetime
+
+import pandas as pd
+
+from herbie import Herbie, config
+
+now = datetime.now()
+latest = pd.Timestamp("now").floor("6h") - pd.Timedelta("6h")
+
+save_dir = config["default"]["save_dir"] / "Herbie-Tests-Data/"
+
+# Remove all previous test data
+for i in (save_dir / "hrdps").rglob("*"):
+    if i.is_file():
+        i.unlink()
+
+
+def test_hrdps_download():
+    H = Herbie(
+        latest,
+        model="hrdps",
+        product="continental/2.5km",
+        variable="TMP",
+        level="AGL-2m",
+        overwrite=True,
+        save_dir=save_dir,
+    )
+    f = H.download()
+    assert H.get_localFilePath().exists()
+    f.unlink()
+
+
+def test_hrdps_xarray():
+    H = Herbie(
+        latest,
+        model="hrdps",
+        product="continental/2.5km",
+        variable="TMP",
+        level="AGL-2m",
+        overwrite=True,
+        save_dir=save_dir,
+    )
+    H.xarray(remove_grib=False)
+    assert H.get_localFilePath().exists()
+    H.get_localFilePath().unlink()
+
+
+def test_hrdps_to_netcdf():
+    """Check that a xarray Dataset can be written to a NetCDF file.
+
+    It is important that I have haven't put any python objects in the
+    xarray Dataset attributes.
+    """
+    H = Herbie(
+        latest,
+        model="hrdps",
+        product="continental/2.5km",
+        variable="TMP",
+        level="AGL-2m",
+        overwrite=True,
+        save_dir=save_dir,
+    )
+    ds = H.xarray(remove_grib=False)
+    ds.to_netcdf(save_dir / "test_hrdps_to_netcdf.nc")