Merge pull request #529 from jacob1299/fix/rrfs-2dfld-product

Register RRFS 2dfld product after NOAA file split

Author: blaylockbk

docs/gallery/noaa_models/rrfs.ipynb

@@ -633,6 +633,8 @@
    "source": [
     "### Other products\n",
     "\n",
+    "RRFS also publishes `natlev` (native model levels), `2dfld` (2D surface/post-processed fields), `testbed`, and `ififip` products.\n",
+    "\n",
     "> Reading natlev data into xarray causes my kernel to crash\n"
    ]
   },

src/herbie/models/rrfs.py

@@ -6,7 +6,7 @@
 Herbie(date, model='rrfs', ...)
 
 fxx : int
-product : {"prs", "nat", "testbed", "ififip"}
+product : {"prs", "nat", "2dfld", "testbed", "ififip"}
 member : {None, int}
     None for deterministic run, int (1-5) for ensemble members
 domain : {"conus", "alaska", "hawaii", "puerto rico", "na"}
@@ -26,6 +26,7 @@ def template(self):
         self.PRODUCTS = {
             "prslev": "pressure level fields",
             "natlev": "native level fields",
+            "2dfld": "2D surface/post-processed fields",
             "testbed": "testbed fields",
             "ififip": "icing/freezing fields",
         }

tests/test_rrfs.py

@@ -97,3 +97,17 @@ def test_rrfs_natlev_file_exists():
     )
     assert H.grib, "RRFS natlev grib2 file not found"
     assert H.idx, "RRFS natlev index file not found"
+
+
+def test_rrfs_2dfld_product_accepted():
+    """2dfld should be a valid product and default to domain='conus'."""
+    H = Herbie(
+        today,
+        model="rrfs",
+        product="2dfld",
+        fxx=0,
+        save_dir=save_dir,
+    )
+    assert H.product == "2dfld"
+    assert H.domain == "conus"
+    assert "2dfld" in H.SOURCES["aws"]