refactor(Tests): check if alert exists directly from test current_alert_id

Author: harunbleech

includes/features/class-enqueue-scripts.php

@@ -100,15 +100,16 @@ public function enqueue_block_editor_assets() {
 			wp_enqueue_script( 'vrts-editor' );
 
 			// Localize scripts.
-			$test = (object) Test::get_item_by_post_id( $post->ID );
+			$test_id = Test::get_item_id( $post->ID );
+			$test = (object) Test::get_item( $test_id );
 
 			wp_localize_script(
 				'vrts-editor',
 				'vrts_editor_vars',
 				[
 					'plugin_name' => vrts()->get_plugin_info( 'name' ),
 					'rest_url' => esc_url_raw( rest_url() ),
-					'has_post_alert' => Test::has_post_alert( $post->ID ),
+					'has_post_alert' => isset( $test->current_alert_id ) ? ! is_null( $test->current_alert_id ) : false,
 					'base_screenshot_url' => Image_Helpers::get_screenshot_url( $test, 'base' ),
 					'base_screenshot_date' => Date_Time_Helpers::get_formatted_date_time( $test->base_screenshot_date ?? null ),
 					'remaining_tests' => Subscription::get_remaining_tests(),

includes/features/class-metaboxes.php

@@ -133,7 +133,7 @@ public function render_metabox() {
 			'plugin_url' => Url_Helpers::get_page_url( 'tests' ),
 			'run_tests_checked' => $run_tests_checked,
 			'field_test_status_key' => self::$field_test_status_key,
-			'has_post_alert' => Test::has_post_alert( $post_id ),
+			'has_post_alert' => isset( $test->current_alert_id ) ? ! is_null( $test->current_alert_id ) : false,
 			'base_screenshot_url' => Image_Helpers::get_screenshot_url( $test, 'base' ),
 			'base_screenshot_date' => Date_Time_Helpers::get_formatted_date_time( $test->base_screenshot_date ),
 			'testing_status_instructions' => $testing_status_instructions,

includes/models/class-test.php

@@ -458,30 +458,6 @@ public static function get_service_test_id_by_post_id( $post_id = 0 ) {
 		return $service_test_id;
 	}
 
-	/**
-	 * Does an alert exits?
-	 *
-	 * @param int $post_id the id of the post.
-	 *
-	 * @return boolean
-	 */
-	public static function has_post_alert( $post_id = 0 ) {
-		global $wpdb;
-
-		$tests_table = Tests_Table::get_table_name();
-
-		// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching -- It's ok.
-		$current_alert_id = $wpdb->get_var(
-			$wpdb->prepare(
-				// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- It's ok.
-				"SELECT current_alert_id FROM $tests_table WHERE post_id = %d",
-				$post_id
-			)
-		);
-
-		return null === $current_alert_id ? false : true;
-	}
-
 	/**
 	 * Get total test items from database
 	 *