add comments

Author: CascadingRadium

index_alias_impl.go

@@ -629,6 +629,7 @@ func preSearchRequired(ctx context.Context, req *SearchRequest, m mapping.IndexM
 				return nil, err
 			}
 			if fs != nil {
+				// safe to ignore error from VisitFields, as our func never returns one
 				fs.VisitFields(func(field string) (bool, error) {
 					if sm.SynonymSourceForPath(field) != "" {
 						synonyms = true

registry/nested.go

@@ -120,6 +120,7 @@ func (nfc *NestedFieldCache) IntersectsPrefix(fieldPaths search.FieldSet) bool {
 func (nfc *NestedFieldCache) prefixMatch(prefix string, fieldPaths search.FieldSet) (common bool, any bool) {
 	common = true
 	any = false
+	// safe to ignore error from VisitFields, as our func never returns one
 	fieldPaths.VisitFields(func(path string) (bool, error) {
 		has := strings.HasPrefix(path, prefix)
 		if has {

search/util.go

@@ -278,6 +278,7 @@ type BM25Stats struct {
 	FieldCardinality map[string]int `json:"field_cardinality"`
 }
 
+// FieldSet represents a set of queried fields and related helper methods.
 type FieldSet interface {
 	// AddField adds a field to the set.
 	AddField(field string)