Skip to content

Commit f48c92f

Browse files
capemoxclaude
andcommitted
refactor: rename adjustDocumentMatch to adjustKNNDocumentMatch
The method only adjusts a hit when a corresponding KNN hit exists (it is called solely from the knnHits != nil branches). Rename it to make that scope explicit, per review feedback. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 7f62df9 commit f48c92f

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

search/collector/topn.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ func (hc *TopNCollector) Collect(ctx context.Context, searcher search.Searcher,
383383
}
384384
if next != nil {
385385
if hc.knnHits != nil {
386-
err = hc.adjustDocumentMatch(searchContext, reader, next)
386+
err = hc.adjustKNNDocumentMatch(searchContext, reader, next)
387387
if err != nil {
388388
break
389389
}
@@ -414,7 +414,7 @@ func (hc *TopNCollector) Collect(ctx context.Context, searcher search.Searcher,
414414
currRoot := hc.nestedStore.Current()
415415
if currRoot != nil {
416416
if hc.knnHits != nil {
417-
err = hc.adjustDocumentMatch(searchContext, reader, currRoot)
417+
err = hc.adjustKNNDocumentMatch(searchContext, reader, currRoot)
418418
if err != nil {
419419
return err
420420
}
@@ -482,9 +482,9 @@ func (hc *TopNCollector) Collect(ctx context.Context, searcher search.Searcher,
482482

483483
var sortByScoreOpt = []string{"_score"}
484484

485-
// adjustDocumentMatch merges any KNN hit corresponding to d into d. Callers
485+
// adjustKNNDocumentMatch merges any KNN hit corresponding to d into d. Callers
486486
// must only invoke it when hc.knnHits != nil (checked at the call sites).
487-
func (hc *TopNCollector) adjustDocumentMatch(ctx *search.SearchContext,
487+
func (hc *TopNCollector) adjustKNNDocumentMatch(ctx *search.SearchContext,
488488
reader index.IndexReader, d *search.DocumentMatch) (err error) {
489489
d.ID, err = reader.ExternalID(d.IndexInternalID)
490490
if err != nil {

0 commit comments

Comments
 (0)