refactor(migration): use global 48h checkpoint expiration

Author: esaugomez31

__tests__/screens/account-migration/hooks/use-migration-checkpoint.spec.ts

@@ -106,7 +106,7 @@ describe("useMigrationCheckpoint", () => {
   })
 
   it("ignores expired checkpoint and removes from storage", async () => {
-    const expiredTimestamp = Date.now() - 25 * 60 * 60 * 1000 // 25 hours ago
+    const expiredTimestamp = Date.now() - 49 * 60 * 60 * 1000
     mockLoadJson.mockResolvedValue({
       step: MigrationCheckpoint.BackupAlerts,
       savedAt: expiredTimestamp,
@@ -120,23 +120,8 @@ describe("useMigrationCheckpoint", () => {
     expect(mockRemove).toHaveBeenCalledWith("migrationCheckpoint")
   })
 
-  it("ignores expired backup method checkpoint after 1 hour", async () => {
-    const expiredTimestamp = Date.now() - 2 * 60 * 60 * 1000 // 2 hours ago
-    mockLoadJson.mockResolvedValue({
-      step: MigrationCheckpoint.BackupMethod,
-      savedAt: expiredTimestamp,
-    })
-
-    const { result } = renderHook(() => useMigrationCheckpoint())
-
-    await act(async () => {})
-
-    expect(result.current.checkpoint).toBeNull()
-    expect(mockRemove).toHaveBeenCalledWith("migrationCheckpoint")
-  })
-
-  it("keeps valid backup method checkpoint within 1 hour", async () => {
-    const recentTimestamp = Date.now() - 30 * 60 * 1000 // 30 minutes ago
+  it("keeps valid checkpoint within 48 hours", async () => {
+    const recentTimestamp = Date.now() - 47 * 60 * 60 * 1000
     mockLoadJson.mockResolvedValue({
       step: MigrationCheckpoint.BackupMethod,
       savedAt: recentTimestamp,

app/screens/account-migration/hooks/use-migration-checkpoint.ts

@@ -3,8 +3,7 @@ import { useCallback, useEffect, useState } from "react"
 import { loadJson, remove, saveJson } from "@app/utils/storage"
 
 const STORAGE_KEY = "migrationCheckpoint"
-const SHORT_EXPIRATION_MS = 60 * 60 * 1000 // 1 hour
-const DEFAULT_EXPIRATION_MS = 24 * SHORT_EXPIRATION_MS // 24 hours
+const EXPIRATION_MS = 48 * 60 * 60 * 1000
 
 export const MigrationCheckpoint = {
   BackupMethod: "backupMethod",
@@ -15,12 +14,6 @@ export const MigrationCheckpoint = {
 export type MigrationCheckpointType =
   (typeof MigrationCheckpoint)[keyof typeof MigrationCheckpoint]
 
-const checkpointExpirationMap: Record<MigrationCheckpointType, number> = {
-  [MigrationCheckpoint.BackupMethod]: SHORT_EXPIRATION_MS,
-  [MigrationCheckpoint.CloudBackup]: DEFAULT_EXPIRATION_MS,
-  [MigrationCheckpoint.BackupAlerts]: DEFAULT_EXPIRATION_MS,
-}
-
 const checkpointRouteMap = {
   [MigrationCheckpoint.BackupMethod]: "sparkBackupMethodScreen",
   [MigrationCheckpoint.CloudBackup]: "sparkCloudBackupScreen",
@@ -50,7 +43,7 @@ export const useMigrationCheckpoint = () => {
       }
 
       const typedStep = step as MigrationCheckpointType
-      if (Date.now() - savedAt > checkpointExpirationMap[typedStep]) {
+      if (Date.now() - savedAt > EXPIRATION_MS) {
         remove(STORAGE_KEY)
         setLoading(false)
         return